From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7137 invoked by alias); 13 Apr 2016 14:48:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7015 invoked by uid 89); 13 Apr 2016 14:48:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 13 Apr 2016 14:48:26 +0000 Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 14.7B.09012.DA55E075; Wed, 13 Apr 2016 16:20:29 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.98) with Microsoft SMTP Server id 14.3.248.2; Wed, 13 Apr 2016 10:48:24 -0400 Subject: Re: [PATCH] Fix and improve comment in gdb_remote_download To: Pedro Alves , References: <1460557393-12354-1-git-send-email-simon.marchi@ericsson.com> <570E5BCF.50901@redhat.com> From: Simon Marchi Message-ID: <570E5C37.30206@ericsson.com> Date: Wed, 13 Apr 2016 14:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <570E5BCF.50901@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00282.txt.bz2 On 16-04-13 10:46 AM, Pedro Alves wrote: > On 04/13/2016 03:23 PM, Simon Marchi wrote: >> This patch fixes the current comment in gdb_remote_download, which is >> false (the "except if that's already where it is" part). It also >> improves it, by explaining why pass TOFILE through standard_output_file, >> even it is an absolute path. >> >> gdb/testsuite/ChangeLog: >> >> * lib/gdb.exp (gdb_remote_download): Fix and extend comment. > > OK. > > Thanks, > Pedro Alves > Thanks, pushed.