From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8411 invoked by alias); 13 Apr 2016 12:18:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8401 invoked by uid 89); 13 Apr 2016 12:18:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=fred, Fred, H*r:ip*10.7.209.27, H*RU:HELO X-HELO: mga14.intel.com Received: from mga14.intel.com (HELO mga14.intel.com) (192.55.52.115) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Apr 2016 12:18:36 +0000 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 13 Apr 2016 05:18:35 -0700 X-ExtLoop1: 1 Received: from wtedesch-mobl2.ger.corp.intel.com (HELO [172.28.205.68]) ([172.28.205.68]) by orsmga003.jf.intel.com with ESMTP; 13 Apr 2016 05:18:35 -0700 Subject: Re: [PATCH V2 1/2] Add redundant target descriptor for tdesc(amd64|i386)_avx_mpx_* To: Pedro Alves , gdb-patches References: <1457025942-23711-1-git-send-email-walfred.tedeschi@intel.com> <1457025942-23711-2-git-send-email-walfred.tedeschi@intel.com> <570E360F.7060501@redhat.com> From: Walfred Tedeschi Message-ID: <570E3919.6040406@intel.com> Date: Wed, 13 Apr 2016 12:18:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <570E360F.7060501@redhat.com> Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00271.txt.bz2 Am 4/13/2016 um 2:05 PM schrieb Pedro Alves: > On 03/03/2016 05:25 PM, Walfred Tedeschi wrote: >> Add a redundant target description for the MPX and AVX case using a >> combined feature name to reflect that, i.e. avx-mpx. > > It's better when commit logs are self-contained and don't > depend on info in the cover letter. The cover letter doesn't > make it to git. > > E.g., > > ~~ > Subject: Add target descriptions for AVX + MPX > > The current MPX target descriptions assume that MPX is always > combined with AVX, however that's not correct. We can have > machines with MPX and without AVX; or machines with AVX > and without MPX. > > This patch adds new target descriptions for machines that > support both MPX and AVX, as duplicates of the existing > MPX descriptions. The following commit will remove AVX from > the MPX-only descriptions. > ~~ > > (Note s/descriptors/descriptions in subject) > Ok, you are right. Intention was to present the full picture. But then=20 this is lost in the commit itself. >> >> Usage of both series of target descriptor (avx-mpx and mpx) were also fi= xed. > > I don't understand what this means. > It is that the switch and the flags used to select the right descriptor=20 was also adapted. >> +++ b/gdb/features/i386/i386-avx-mpx-linux.xml >> @@ -0,0 +1,19 @@ >> + >> + >> + >> + > > Missing space before "-". (Please audit the other added files.) Will address that. > >> +++ b/gdb/features/i386/i386-avx-mpx.xml >> @@ -0,0 +1,17 @@ >> + >> + >> + >> + > > Shouldn't this say "and AVX" as well? > > Yes, i have to improve the comment for the XML files. Thanks! >> + >> + >> + >> + i386 >> + >> + >> + >> + >> + >> diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in > >> + case X86_XSTATE_AVX_MPX_MASK: >> + if (is_x32) >> + return tdesc_x32_linux; /* No AVX and MPX is not available in x32.= */ > > > The comment sounds odd to me. Does this intend to say: > > /* Neither AVX nor MPX are available on x32. */ > > ? It is odd. I will take a look in fact it's MPX will not be available for=20 x32. > > Is it really true that x32 does not support AVX? > > Thanks, > Pedro Alves > Thanks again! -Fred Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928