From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65689 invoked by alias); 12 Apr 2016 18:45:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65680 invoked by uid 89); 12 Apr 2016 18:45:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=160412 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 Apr 2016 18:45:57 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E57FE46269; Tue, 12 Apr 2016 18:45:55 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3CIjsgk022773; Tue, 12 Apr 2016 14:45:55 -0400 Subject: Re: [PATCH] gdbserver-base.exp: Copy file to standard output directory in ${board}_download To: Simon Marchi , gdb-patches@sourceware.org References: <1460483287-23953-1-git-send-email-simon.marchi@ericsson.com> <570D39A7.7040001@redhat.com> <570D403F.5010406@ericsson.com> Cc: qiyaoltc@gmail.com From: Pedro Alves Message-ID: <570D4262.90201@redhat.com> Date: Tue, 12 Apr 2016 18:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <570D403F.5010406@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00255.txt.bz2 On 04/12/2016 07:36 PM, Simon Marchi wrote: > On 16-04-12 02:08 PM, Pedro Alves wrote: >> On 04/12/2016 06:48 PM, Simon Marchi wrote: >> >>> proc ${board}_download { board host dest } { >>> + file copy -force $host [standard_output_file $dest] >>> return $host >>> } >> >> I think this should be: >> >> set dest [standard_output_file $dest] >> file copy -force $host $dest >> return $dest > > Doh, you're right. > >> Don't we need to consider the case of $dest being an absolute path? > > I thought it wouldn't be better not, since we don't even want for tests to > be able to write outside the standard output directory. I guess that if a > test tries to download to /foo/bar, it will end up as > outputs/gdb.blah/thetest/foo/bar. Then I would say the test would be at fault. OK, but I think we should put a comment to the effect in place. After all, we'll be pointing other people that run into this in their boards to this commit. :-) Otherwise LGTM. (Let's wait a bit to give Yao a chance to comment though.) Thanks, Pedro Alves