From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51679 invoked by alias); 11 Apr 2016 18:40:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51643 invoked by uid 89); 11 Apr 2016 18:40:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=vocabulary, brings, countless, ooc X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 Apr 2016 18:40:13 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA5F57822D; Mon, 11 Apr 2016 18:40:12 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3BIeBM1003105; Mon, 11 Apr 2016 14:40:12 -0400 Subject: Re: [PATCH 1/4] native-gdbserver: Clear isremote flag in board info To: Simon Marchi , gdb-patches@sourceware.org References: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> Cc: Simon Marchi From: Pedro Alves Message-ID: <570BEF8B.70203@redhat.com> Date: Mon, 11 Apr 2016 18:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00219.txt.bz2 On 04/06/2016 04:15 AM, Simon Marchi wrote: > There seems to be some confusion globally in the testsuite about what's > native and what's not, what's remote and what's not. It's probably > because of the overlap in vocabulary between DejaGnu and GDB. Yeah. This whole mess, and the confusion it brings in, has been a known issue for a long time, and I'm very glad someone's doing something about it! > Because of this confution, a lot of tests in the testsuite don't check > for the right kind of target remote. For example, some use [is_remote > target] (which checks whether the DejaGnu target is remote), when what > they really want to know is whether GDB is using its remote target (e.g. > because feature X is only available when GDB debugs natively). Those > should use [gdb_is_target_remote] instead. Note gdb_is_target_remote is a bit "heavy" in that it runs a gdb command to check what is the target _right now_. For checks at the top of testcases that want to bail out early before even gdb is started, it's cheaper to check: [target_info gdb_protocol] == "remote" || [target_info gdb_protocol] == "extended-remote"] (we should have a proc for that...) My fault for introducing gdb_is_target_remote and using in several places, when the "cheaper" test would do. > Also, some of them require careful analysis/discussion. I'd still like > to submit this patch right now anyway, since I don't want to spend > countless hours fixing everything and then be told that my approach is > wrong... I'd like to be told right away, if that's the case :). I think you're on the right track. > So, I > have included a few examples of fixed tests in the following patches, > but it's by no means comprehensive. > > --- a/gdb/testsuite/boards/native-gdbserver.exp > +++ b/gdb/testsuite/boards/native-gdbserver.exp > @@ -36,26 +36,6 @@ set_board_info exit_is_reliable 1 > # We will be using the standard GDB remote protocol. > set_board_info gdb_protocol "remote" > > -proc ${board}_spawn { board cmd } { > - global board_info > +set baseboard [lindex [split $board "/"] 0] > +set board_info($baseboard,isremote) 0 OOC, don't we need the "global" declarations as in native-extended-gdbserver.exp? You're probably already thinking of doing this, but I'll state it explicitly anyway: it'd be nice to move this isremote frobbing to a shared .exp file, so that boards that need it can just source the file. Thanks, Pedro Alves