From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74134 invoked by alias); 11 Apr 2016 18:16:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74116 invoked by uid 89); 11 Apr 2016 18:16:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=exercises, Hx-languages-length:771, brand X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 Apr 2016 18:16:43 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 20E00C05E154; Mon, 11 Apr 2016 18:16:42 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3BIGfhh027075; Mon, 11 Apr 2016 14:16:41 -0400 Subject: Re: [PATCH 3/4] Fix detach.exp remote check To: Simon Marchi , gdb-patches@sourceware.org References: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> <1459912543-15328-3-git-send-email-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <570BEA08.2070806@redhat.com> Date: Mon, 11 Apr 2016 18:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1459912543-15328-3-git-send-email-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00217.txt.bz2 On 04/06/2016 04:15 AM, Simon Marchi wrote: > This test seems to work with both native-gdbserver and > native-extended-gdbserver, so I removed the remote check. > > When running with native-gdbserver (a stub-like target), detach makes > gdbserver stop and gdb disconnect. runto_main just spawns a brand new > gdbserver. So it tests the exact same thing twice. It doesn't hurt > though. It's not exactly the same thing, as the second test runs with the same gdb, so it exercises "run" or "target connect" after a previous "detach", which can expose problems with stale state from the previous connection. So also useful. > gdb/testsuite/ChangeLog: > > * gdb.base/detach.exp: Remove is_remote check. OK. Thanks, Pedro Alves