From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61165 invoked by alias); 8 Apr 2016 22:33:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 60201 invoked by uid 89); 8 Apr 2016 22:33:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1355 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 08 Apr 2016 22:33:13 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 05FD7B5C0E; Fri, 8 Apr 2016 22:33:12 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u38MXAdc010041; Fri, 8 Apr 2016 18:33:11 -0400 Subject: Re: [PATCH] Make gdb.server/solib-list.exp work for remote targets To: Simon Marchi , gdb-patches@sourceware.org References: <1460153899-5185-1-git-send-email-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <570831A6.7070901@redhat.com> Date: Fri, 08 Apr 2016 22:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1460153899-5185-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00191.txt.bz2 Looks good, though see comments below. Thanks for doing this. On 04/08/2016 11:18 PM, Simon Marchi wrote: > gdb/testsuite/ChangeLog: > > * gdb.server/solib-list.exp: Allow running with remote targets. Pedantically, this is really a "why", not a "what". Should be something around: * gdb.server/solib-list.exp: Remove is_remote check. Pass shlib= to gdb_compile. Don't link shared library with -soname. Call gdb_remote_download instead of gdb_load_shlibs. Run binary filename through "readlink -f" on the target. > @@ -75,8 +74,7 @@ foreach nonstop { 0 1 } { with_test_prefix "non-stop $nonstop" { > # Note we pass ${interp_system}, the program gdbserver spawns, as > # argument here, instead of using gdb_load, because we don't want > # to download the interpreter to the target (it's already there) > - # or to the test output directory. Did you remove this line on purpose? If so, missing period. :-) BTW, I actually meant to extended it to: "or to the test output directory, when local testing." before pushing the previous patch, but forgot. > - set res [gdbserver_spawn "${interp_system} ${binfile}"] > + set res [gdbserver_spawn "${interp_system} ${remote_binfile}"] > set gdbserver_protocol [lindex $res 0] > set gdbserver_gdbport [lindex $res 1] Thanks, Pedro Alves