From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1969 invoked by alias); 7 Apr 2016 13:25:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1954 invoked by uid 89); 7 Apr 2016 13:25:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=H*f:sk:1459983, H*MI:sk:1459983, H*i:sk:1459983, Hx-languages-length:2144 X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 07 Apr 2016 13:25:28 +0000 Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 7A.D9.22441.0AF56075; Thu, 7 Apr 2016 15:24:48 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.77) with Microsoft SMTP Server id 14.3.248.2; Thu, 7 Apr 2016 09:25:25 -0400 Subject: Re: [PATCH] Fix gdb.compile/compile.exp shlib regression To: Pedro Alves , References: <1459983981-19198-1-git-send-email-palves@redhat.com> From: Simon Marchi Message-ID: <57065FC5.30108@ericsson.com> Date: Thu, 07 Apr 2016 13:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459983981-19198-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00148.txt.bz2 On 16-04-06 07:06 PM, Pedro Alves wrote: > Commit 6e774b13c3b8 (Make ftrace tests work with remote targets) made > a few gdb.compile/compile.exp tests disappear: > > -PASS: gdb.compile/compile.exp: call shared library function > -PASS: gdb.compile/compile.exp: expect 1 > -PASS: gdb.compile/compile.exp: modify shared library variable > -PASS: gdb.compile/compile.exp: expect 15 > > This is because the test uses ldflags instead of using the shlib > option, so it misses linking with -rpath, resulting in: > > (gdb) run > Starting program: .../compile/compile-shlib > .../compile/compile-shlib: error while loading shared libraries: compile-shlib.so: cannot open shared object file: No such file or directory > [Inferior 1 (process 18014) exited with code 0177] > > I also noticed we were missing a gdb_load_shlibs call. > > gdb/testsuite/ChangeLog: > yyyy-mm-dd Pedro Alves > > * gdb.compile/compile.exp: Use gdb_compile with "shlib=" option > instead of build_executable. Use gdb_load_shlibs. > --- > gdb/testsuite/gdb.compile/compile.exp | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/gdb.compile/compile.exp b/gdb/testsuite/gdb.compile/compile.exp > index 07a7568..a8bfc24 100644 > --- a/gdb/testsuite/gdb.compile/compile.exp > +++ b/gdb/testsuite/gdb.compile/compile.exp > @@ -362,13 +362,17 @@ if {[skip_shlib_tests]} { > } > > set libbin [standard_output_file ${testfile}-shlib.so] > +set binfile [standard_output_file ${testfile}-shlib] > + > if { [gdb_compile_shlib ${srcdir}/${subdir}/${srcfile2} $libbin {debug}] != "" > - || [build_executable $testfile ${testfile}-shlib $srcfile \ > - [list debug ldflags=$libbin]] == -1 } { > + || [gdb_compile ${srcdir}/${subdir}/${srcfile} $binfile executable \ > + [list debug shlib=$libbin]] == -1 } { > return -1 > } > > -clean_restart ${testfile}-shlib > +clean_restart $binfile > +gdb_load_shlibs $libbin > + > if ![runto_main] { > return -1 > } > That looks good, thanks. Indeed, gdb_load_shlibs is required to make it work on a remote gdbserver test config.