From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98511 invoked by alias); 6 Apr 2016 23:36:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98500 invoked by uid 89); 6 Apr 2016 23:36:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=guides, camp X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 06 Apr 2016 23:36:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6D0C28F01F; Wed, 6 Apr 2016 23:36:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u36NaZGi011303; Wed, 6 Apr 2016 19:36:36 -0400 Subject: Re: [PATCH] value: Make accessor methods' parameters const-correct To: Martin Galvan , gdb-patches@sourceware.org, tom@tromey.com References: <1459974933-616-1-git-send-email-martin.galvan@tallertechnologies.com> From: Pedro Alves Message-ID: <57059D83.2010403@redhat.com> Date: Wed, 06 Apr 2016 23:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1459974933-616-1-git-send-email-martin.galvan@tallertechnologies.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00144.txt.bz2 On 04/06/2016 09:35 PM, Martin Galvan wrote: > I did a quick pass over value.c and value.h and made some of the accessor methods' > parameters const-correct. Besides the obvious benefits, this is required if we > want to use them on values that are already declared as const (such as the parameters > to lval_funcs). I also const-ified some of the pass-by-value parameters; while > they're not as important it's still nice to have them like that. Thanks for doing this. Const on pointer parameters is certainly useful. But since you asked me [ :-) ], I'm on the "const on value params is mostly useless clutter" camp. It's something you don't see many style guides requiring, and it's something gdb hasn't been doing either. So personally I'd prefer a patch without those bits. > > There's probably a lot more stuff that can be made const, here and elsewhere. > > I have write access and copyright assignment. Ok to commit? Thanks, Pedro Alves