From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37617 invoked by alias); 6 Apr 2016 22:24:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37607 invoked by uid 89); 6 Apr 2016 22:24:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Scheme, sk:extensi, light X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 06 Apr 2016 22:24:15 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1FB8AC057FAD; Wed, 6 Apr 2016 22:24:14 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u36MOCNw012338; Wed, 6 Apr 2016 18:24:12 -0400 Subject: Re: [PATCH] Eliminate -var-create error for optzd ptr to struct To: Don Breazeal , Yao Qi References: <1459888769-18875-1-git-send-email-donb@codesourcery.com> <86lh4rm7kq.fsf@gmail.com> <5705828A.3030708@codesourcery.com> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: <57058C8C.5060908@redhat.com> Date: Wed, 06 Apr 2016 22:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <5705828A.3030708@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00142.txt.bz2 On 04/06/2016 10:41 PM, Don Breazeal wrote: > On 4/6/2016 2:04 AM, Yao Qi wrote: > Question: in light of Pedro's comments regarding > gdbscm_value_optimized_out_p and valpy_get_is_optimized_out: > >> A RETURN_MASK_ALL swallows Ctrl-C/QUIT, and that's almost >> always a bug. The cases you mention translate a QUIT to >> a python/scheme exception, which is not the same as just >> swallowing the exception. > > Would you still like for me to follow up with a patch to remove the > TRY/CATCH blocks around the calls to value_optimized_out in those two > functions? Or do we want to leave it as-is so that the QUIT handling > remains unchanged? Please leave them as is. We need to translate gdb exceptions to Python/Scheme exceptions at the gdb <-> extension-language boundaries. Those gdb functions in question will be returning to the Python/Scheme runtimes, which are not prepared to unwind correctly on a gdb exception. Thanks, Pedro Alves