From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114525 invoked by alias); 5 Apr 2016 18:23:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114466 invoked by uid 89); 5 Apr 2016 18:23:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 05 Apr 2016 18:23:32 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5EA0FFB77F; Tue, 5 Apr 2016 18:23:31 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u35INU5V015418; Tue, 5 Apr 2016 14:23:30 -0400 Subject: Re: [PATCH v4 00/11] [PR gdb/14441] Support C++0x rvalue references in gdb To: Artemiy Volkov , Keith Seitz References: <1457147955-21871-1-git-send-email-artemiyv@acm.org> <1458593958-25656-1-git-send-email-artemiyv@acm.org> <56FD89F7.1020409@redhat.com> <20160402084706.GD7371@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <570402A1.6030600@redhat.com> Date: Tue, 05 Apr 2016 18:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160402084706.GD7371@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00100.txt.bz2 On 04/02/2016 09:47 AM, Artemiy Volkov wrote: > On Thu, Mar 31, 2016 at 01:35:03PM -0700, Keith Seitz wrote: >> On 03/21/2016 01:59 PM, Artemiy Volkov wrote: >>> Hi all, >>> >>> this is my fourth take on fixing gdb/14441 which deals with C++0x rvalue >>> references. >>> >> >> There are two small nits (see replies in #8 and #9), otherwise, this >> series looks ready for a final evaluation by a maintainer. >> >> Since the nits are really minor, I recommend just replying [to my >> messages] with corrections on those two specific patches instead of >> reposting the entire series. > > Done and done. I hope that's OK that I didn't resend the description and > changelog parts. > >> >> Thank you for your patch (and patience)! > > Same here about the patience part :) Thanks you very much for this patch set, and big thanks to Keith for the review. I read the series and it looks pretty good to me. The only thing I'm not sure about is the hardcoding of "-std=c++11" in tests. GCC 6 switches to -std=gnu++14 by default, for instance, and I wouldn't want the tests to not cover whatever the compiler uses by default. Note also that that's -std=gnu++14, not the stricter -std=c++14 mode. Could we make the testcases gracefully skip rvalue reference bits using #if __cplusplus? BTW, please fix up all comments and commit logs to mention C++11 instead of C++0x. :-) Thanks, Pedro Alves