From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108252 invoked by alias); 5 Apr 2016 11:59:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108230 invoked by uid 89); 5 Apr 2016 11:59:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1531 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 05 Apr 2016 11:59:17 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EABA2A3B45; Tue, 5 Apr 2016 11:59:15 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u35BxEAa030997; Tue, 5 Apr 2016 07:59:14 -0400 Subject: Re: [PATCH] testsuite: Update py-mi-objfile to expect console format print To: Catalin-Dan Udma , Catalin Udma , "gdb-patches@sourceware.org" References: <1459851290-13123-1-git-send-email-catalin.udma@freescale.com> <57039A9E.4010408@redhat.com> From: Pedro Alves Message-ID: <5703A892.6090003@redhat.com> Date: Tue, 05 Apr 2016 11:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00071.txt.bz2 On 04/05/2016 12:45 PM, Catalin-Dan Udma wrote: >> On 04/05/2016 11:14 AM, Catalin Udma wrote: >>> --- a/gdb/testsuite/gdb.python/py-mi-objfile-gdb.py >>> +++ b/gdb/testsuite/gdb.python/py-mi-objfile-gdb.py >>> @@ -24,4 +24,4 @@ import gdb >>> gdb.execute("set width 101", to_string=True) >>> # And finally a command that will use the original MI stream, which in a >>> # buggy gdb will use just-freed data. >>> -gdb.execute("list") >>> +gdb.execute("list main") >> >> Do the comments in the test still make sense? >> From the comment, sounds like the test might no longer be covering >> what it intended? I.e. do we "use the original MI stream" ? >> >> Thanks, >> Pedro Alves > > [Catalin Udma] Indeed, the original crash is no longer reproducible: I manually reverted the fixes > for that crash (gdb/cli/cli-logging.c, gdb/mi/mi-out.c) and the crash is not reproducible anymore > when running py-mi-objfile.exp. > It reproduces if I revert also this patch " python: Use console format for output of gdb.execute command" > > Updating the comments would be enough and let the test validate the same scenario? I think it's good to keep validating the same scenario. Though maybe there's something else we could add that uses the MI stream, that'd also expose the crash? Maybe gdb.execute ("interpreter-exec mi \"-gdb-show width\"") would work? > "+# And finally a command that will use the console stream without redirection" ? Thanks, Pedro Alves