From: Pedro Alves <palves@redhat.com>
To: Catalin Udma <catalin.udma@freescale.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] testsuite: Update py-mi-objfile to expect console format print
Date: Tue, 05 Apr 2016 10:59:00 -0000 [thread overview]
Message-ID: <57039A9E.4010408@redhat.com> (raw)
In-Reply-To: <1459851290-13123-1-git-send-email-catalin.udma@freescale.com>
On 04/05/2016 11:14 AM, Catalin Udma wrote:
> --- a/gdb/testsuite/gdb.python/py-mi-objfile-gdb.py
> +++ b/gdb/testsuite/gdb.python/py-mi-objfile-gdb.py
> @@ -24,4 +24,4 @@ import gdb
> gdb.execute("set width 101", to_string=True)
> # And finally a command that will use the original MI stream, which in a
> # buggy gdb will use just-freed data.
> -gdb.execute("list")
> +gdb.execute("list main")
Do the comments in the test still make sense?
From the comment, sounds like the test might no longer be covering
what it intended? I.e. do we "use the original MI stream" ?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-04-05 10:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 10:16 Catalin Udma
2016-04-05 10:59 ` Pedro Alves [this message]
2016-04-05 11:46 ` Catalin-Dan Udma
2016-04-05 11:59 ` Pedro Alves
2016-04-05 13:08 ` Catalin-Dan Udma
2016-04-05 13:11 ` Pedro Alves
2016-04-05 13:13 ` Pedro Alves
2016-04-05 13:36 ` Catalin-Dan Udma
2016-04-05 13:47 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57039A9E.4010408@redhat.com \
--to=palves@redhat.com \
--cc=catalin.udma@freescale.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox