From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43317 invoked by alias); 5 Apr 2016 09:31:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43303 invoked by uid 89); 5 Apr 2016 09:31:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:HELO, Hx-spam-relays-external:HELO, commercial, Tel X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Apr 2016 09:31:04 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 05 Apr 2016 02:31:02 -0700 X-ExtLoop1: 1 Received: from heckel-mobl3.ger.corp.intel.com (HELO [172.28.205.63]) ([172.28.205.63]) by fmsmga002.fm.intel.com with ESMTP; 05 Apr 2016 02:31:00 -0700 Subject: Re: [PATCH 3/3] fort_dyn_array: Use value constructor instead of raw-buffer manipulation. To: Yao Qi References: <1458204189-13267-1-git-send-email-bernhard.heckel@intel.com> <1458204189-13267-4-git-send-email-bernhard.heckel@intel.com> <868u0tpji4.fsf@gmail.com> Cc: brobecker@adacore.com, gdb-patches@sourceware.org, Keven Boell From: "Heckel, Bernhard" Message-ID: <570385D3.7090704@intel.com> Date: Tue, 05 Apr 2016 09:31:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <868u0tpji4.fsf@gmail.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00063.txt.bz2 T24gMDQvMDQvMjAxNiAxNTo1NCwgWWFvIFFpIHdyb3RlOgo+IEJlcm5oYXJk IEhlY2tlbCA8YmVybmhhcmQuaGVja2VsQGludGVsLmNvbT4gd3JpdGVzOgo+ Cj4+IEluc3RlYWQgb2YgcHJlLWNvbXB1dGluZyBpbmRpY2VzIGludG8gYSBm b3J0cmFuIGFycmF5IHJlLXVzZQo+PiB0aGUgdmFsdWVfKiBpbnRlcmZhY2Vz IHRvIHN1YnNjcmlwdCBhIGZvcnRyYW4gYXJyYXkuCj4gSGksIGNhbiB5b3Ug ZWxhYm9yYXRlIGEgbGl0dGxlIHBsZWFzZT8gIEl0IGxvb2tzIGxpa2UgY2hh bmdlIHRvIG5ldwo+IGludGVyZmFjZSwgYnV0IHdoeSBkb2VzIHRoaXMgZml4 IHRoZSBidWc/IGJlY2F1c2UgdmFsdWVfKiBpbnRlcmZhY2VzCj4gaGF2ZSBi ZWVuIGF3YXJlIG9mIGR5bmFtaWMgdHlwZT8KPgpZZXMsIHlvdSBhcmUgcmln aHQuIHZhbHVlXyogaW50ZXJmYWNlICh2YWx1ZV9maWVsZCkgdGFrZXMgY2Fy ZSBhYm91dCAKdHlwZXMgd2l0aCBkeW5hbWljIGxvY2F0aW9ucy4gVGhpcyBt ZWFucyB0aGUgY29udGVudHMKZm9yIGR5bmFtaWMgZmllbGQgdHlwZXMgb2Yg c3RydWN0dXJlcyBhcmUgbm90IGF0ICJBZGRyX29mICh0eXBlKSArIApUWVBF X0ZJRUxEX0JJVFBPUyAodHlwZSwgaW5kZXgpIC8gOCIgYnV0IGF0IHRoZSB2 YWx1ZQpvZiB0aGUgZHluYW1pYyBsb2NhdGlvbiBhdHRyaWJ1dGUgd2hpY2gg aXMgYWxyZWFkeSByZXNvbHZlZC4KU28sIHN3aXRjaGluZyB0byB0aGUgbmV3 IGludGVyZmFjZXMgc29sdmVzIHRoZSBpc3N1ZSBtZW50aW9uZWQgaW4gdGhl IApjb21taXQgbWVzc2FnZS4KCkludGVsIERldXRzY2hsYW5kIEdtYkgKUmVn aXN0ZXJlZCBBZGRyZXNzOiBBbSBDYW1wZW9uIDEwLTEyLCA4NTU3OSBOZXVi aWJlcmcsIEdlcm1hbnkKVGVsOiArNDkgODkgOTkgODg1My0wLCB3d3cuaW50 ZWwuZGUKTWFuYWdpbmcgRGlyZWN0b3JzOiBDaHJpc3RpbiBFaXNlbnNjaG1p ZCwgQ2hyaXN0aWFuIExhbXByZWNodGVyCkNoYWlycGVyc29uIG9mIHRoZSBT dXBlcnZpc29yeSBCb2FyZDogTmljb2xlIExhdQpSZWdpc3RlcmVkIE9mZmlj ZTogTXVuaWNoCkNvbW1lcmNpYWwgUmVnaXN0ZXI6IEFtdHNnZXJpY2h0IE11 ZW5jaGVuIEhSQiAxODY5MjgK >From gdb-patches-return-130692-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Apr 05 09:53:01 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 91087 invoked by alias); 5 Apr 2016 09:53:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 91070 invoked by uid 89); 5 Apr 2016 09:53:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2296 X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0072.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.72) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Tue, 05 Apr 2016 09:52:50 +0000 Received: from VI1PR0401MB1776.eurprd04.prod.outlook.com (10.165.234.150) by VI1PR0401MB1775.eurprd04.prod.outlook.com (10.165.234.149) with Microsoft SMTP Server (TLS) id 15.1.447.15; Tue, 5 Apr 2016 09:52:45 +0000 Received: from VI1PR0401MB1776.eurprd04.prod.outlook.com ([10.165.234.150]) by VI1PR0401MB1776.eurprd04.prod.outlook.com ([10.165.234.150]) with mapi id 15.01.0447.028; Tue, 5 Apr 2016 09:52:45 +0000 From: Catalin-Dan Udma To: Simon Marchi , Catalin Udma , "gdb-patches@sourceware.org" Subject: RE: [PATCH v2] python: Use console format for output of gdb.execute command Date: Tue, 05 Apr 2016 09:53:00 -0000 Message-ID: References: <1459420984-6582-1-git-send-email-catalin.udma@freescale.com> <5702E514.7000608@ericsson.com> In-Reply-To: <5702E514.7000608@ericsson.com> authentication-results: ericsson.com; dkim=none (message not signed) header.d=none;ericsson.com; dmarc=none action=none header.from=nxp.com; x-ms-office365-filtering-correlation-id: 350d1d83-3ed3-49dc-435b-08d35d3809b4 x-microsoft-exchange-diagnostics: 1;VI1PR0401MB1775;5:6wN2JpygZOQHflnxhI5C5X1uC1kzjwrqqP//pBDx5nd7FlI7eU1ax1S0qqEui9JVh7cicXFeboC3n0q9ITnPmoQfnY3VM7TVtG2U46kby6t7jpRF04Dzv9IDI8qqcYMIgZit+jtgPOELwkng2N+0UQ==;24:+NDVWGl9xpgw3Hs2IFQ2BDCTxWzcmbFvWiBXTtFn94aaQz7/CgLRQvWMI6CdSdv8We6jD9KOwb4QlL2pV/WDzVqWyvcW3iC3I1upJY6WfK8= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB1775; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:VI1PR0401MB1775;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB1775; x-forefront-prvs: 0903DD1D85 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(164054003)(51444003)(377424004)(377454003)(13464003)(1220700001)(107886002)(1096002)(10400500002)(92566002)(87936001)(102836003)(3846002)(586003)(6116002)(189998001)(2906002)(122556002)(3660700001)(2501003)(3280700002)(81166005)(5008740100001)(54356999)(2950100001)(76176999)(50986999)(11100500001)(66066001)(106116001)(86362001)(19580405001)(19580395003)(5004730100002)(33656002)(76576001)(74316001)(5001770100001)(5002640100001)(5003600100002)(2900100001)(15975445007)(77096005)(1720100001)(19625735002)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB1775;H:VI1PR0401MB1776.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2016 09:52:44.9857 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1775 X-SW-Source: 2016-04/txt/msg00064.txt.bz2 Content-length: 2275 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Simon Marchi > On 16-03-31 06:43 AM, Catalin Udma wrote: > > When gdb is started in MI mode, the output of gdb.execute > > command is in MI-format in case when it is executed from python stop > > handler while for all other cases the output is in console-format. > > > > To assure consistent output format, this is fixed by using the console > > format for all python gdb command executions. > > > > PR python/19743 > > > > gdb/ChangeLog: > > 2016-03-31 Catalin Udma > > > > PR python/19743 > > * python/python.c (execute_gdb_command): Use console uiout > > when executing gdb command. > > * utils.c (restore_ui_out_closure): New structure. > > (do_restore_ui_out): New function. > > (make_cleanup_restore_ui_out): Likewise. > > * utils.h (make_cleanup_restore_ui_out): Declare. > > > > gdb/testsuite/ChangeLog: > > 2016-03-31 Catalin Udma > > > > PR python/19743 > > * gdb.python/py-mi-events-gdb.py: New file. > > * gdb.python/py-mi-events.c: New file. > > * gdb.python/py-mi-events.exp: New file. > > > > Signed-off-by: Catalin Udma > > --- > Hi Catalin, >=20 > I think that gdb.python/py-mi-objfile.exp started failing with this commi= t. > Buildbot seems to > agree: >=20 > http://gdb-build.sergiodj.net/cgit/Fedora-x86_64- > m64/.git/tree/?id=3D9473ce97ff66c5f312080c983992b4581accef94 >=20 > I haven't debugged it yet, so I can't tell whether it's gdb or the test w= ho's at > fault. >=20 > Would you have time to take a look? >=20 > Thanks, >=20 > Simon [Catalin Udma] The py-mi-objfile.exp test needs to be fixed. This is exactl= y what my patch is trying to fix: - when the python script is called from command line, it prints the "list" = command in console format - when the python script is called as an event triggered by symbol loading,= the unpatched gdb would prints the "list" command in MI format. With my patch, the output is consi= stent and the python=20 script would print in console format. I'll send a patch updating the py-mi-objfile.exp test to expect the script = printing in console format. Regards, Catalin