Re: [PATCH v2 05/31] 'struct expression *' -> gdb::unique_xmalloc_ptr

Pedro Alves
2016-10-19T21:50:40Z

On 10/19/2016 07:45 PM, Simon Marchi wrote:
> On 2016-10-18 21:11, Pedro Alves wrote:
>> [1] - I'd like to set the rule that types named with an "_up" suffix
>> are unique_ptr typedefs.
>
> I don't mind. It sounds funny when saying it out loud though,

I read it as "<type> u. p.". :-)

> my goal
> from now on will be to introduce a class named "whats".

:-)

> It ends up a
> bit cryptic for somebody that doesn't know about that convention
> (newcomers), but then expression_unique_ptr might be a bit long.
>
> I did a quick grep for various converted struct names allocation
> keywords, I see there is still a
>
> bp_location = XNEWVEC (struct bp_location *, bp_location_count);
>
> Does that need to be converted too?

You mean converted to "new"? No, because that is an array
of pointers, not array of bp_location objects.

Thanks,
Pedro Alves