From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95095 invoked by alias); 20 Oct 2016 04:24:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95062 invoked by uid 89); 20 Oct 2016 04:24:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_40,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*r:112, marc-andre, marc-andre.laperle@ericsson.com, Laperle X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Oct 2016 04:24:03 +0000 Received: by simark.ca (Postfix, from userid 112) id 763261E486; Thu, 20 Oct 2016 00:24:01 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 8D0801E0F5; Thu, 20 Oct 2016 00:23:59 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 20 Oct 2016 04:24:00 -0000 From: Simon Marchi To: Marc-Andre Laperle Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Add a better diagnostic message in mi_gdb_test In-Reply-To: <1473712054-30417-2-git-send-email-marc-andre.laperle@ericsson.com> References: <1473712054-30417-1-git-send-email-marc-andre.laperle@ericsson.com> <1473712054-30417-2-git-send-email-marc-andre.laperle@ericsson.com> Message-ID: <56fdb3e37cf79fdbc9a4620616e6a77b@simark.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.0 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00598.txt.bz2 On 2016-09-12 16:27, Marc-Andre Laperle wrote: > When using mi_gdb_test, if it fails because of the presence of > unexpected output, the error message is only the message passed as > the argument with no indication that there was an unexpected output. > This change adds an additional text to the failure message to > indicate that there was an unexpected output. > > gdb/testsuite/ChangeLog: > > * lib/mi-support.exp (mi_gdb_test): Add additional message > for unexpected output. > > Signed-off-by: Marc-Andre Laperle > --- > gdb/testsuite/lib/mi-support.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/lib/mi-support.exp > b/gdb/testsuite/lib/mi-support.exp > index 7c2bb3e..25995cf 100644 > --- a/gdb/testsuite/lib/mi-support.exp > +++ b/gdb/testsuite/lib/mi-support.exp > @@ -824,7 +824,7 @@ proc mi_gdb_test { args } { > } > -re ".*$mi_gdb_prompt\[ \]*$" { > if ![string match "" $message] then { > - fail "$message" > + fail "$message (unexpected output)" > } > set result 1 > } Looks good to me, more details do not hurt. If it wasn't clear for you, it probably wasn't for some other people too.