From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MT/OJXXjDmC0BQAAWB0awg (envelope-from ) for ; Mon, 25 Jan 2021 10:27:49 -0500 Received: by simark.ca (Postfix, from userid 112) id 8E3061EF80; Mon, 25 Jan 2021 10:27:49 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB22B1E945 for ; Mon, 25 Jan 2021 10:27:48 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CE5743857023; Mon, 25 Jan 2021 15:27:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CE5743857023 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611588467; bh=H8vzlmdxryfIKaiZ6gnjyCG1H37ey7JFjWtBo5idM8g=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=N2/zK00uPH/XD/k6S96kUv50ySH3nAkPoVlfskqfX9OFF+m9UNFBTMrQY2ZAtYC8v oeDovtKJ5mmuMnchCbl5A1qNNlinVDdcnrdHELxyk3bJuO3abcsF2LLlZXdhvovWR5 Qb5HunOkjQLT4mcgJe6I2B51/Ha199xwdF0LRTbo= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1EEDF3857023 for ; Mon, 25 Jan 2021 15:27:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1EEDF3857023 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 10PFRZ9H012965 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Jan 2021 10:27:40 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 10PFRZ9H012965 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5E4E31E945; Mon, 25 Jan 2021 10:27:35 -0500 (EST) Subject: Re: [PATCH][gdb/symtab] Handle DW_AT_ranges with DW_FORM_sec_off in partial DIE To: Bernd Edlinger , Tom de Vries , gdb-patches@sourceware.org References: <20210125122444.GA15885@delia> Message-ID: <56f38801-477e-fa38-5e16-22a4ed73437c@polymtl.ca> Date: Mon, 25 Jan 2021 10:27:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 25 Jan 2021 15:27:35 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Tom Tromey Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-25 7:52 a.m., Bernd Edlinger wrote: > On 1/25/21 1:24 PM, Tom de Vries wrote: >> Hi, >> >> While looking into a failure in gdb.go/package.exp with gcc-11, I noticed that >> gdb shows some complaints when loading the executable (also with gcc-10, where >> the test-case passes): >> ... >> $ gdb -batch -iex "set complaints 100" package.10 -ex start >> During symbol reading: Attribute value is not a constant (DW_FORM_sec_offset) >> Temporary breakpoint 1 at 0x402ae6: file gdb.go/package1.go, line 8. >> During symbol reading: Attribute value is not a constant (DW_FORM_sec_offset) >> During symbol reading: Invalid .debug_rnglists data (no base address) >> ... >> >> Fix this by using as_unsigned () to read DW_AT_ranges in the partial DIE >> reader, similar to how that is done in dwarf2_get_pc_bounds. >> >> Tested on x86_64-linux. >> >> Any comments? >> > > Oh, interesting. > > This is exactly what I have posted here: > > https://sourceware.org/pipermail/gdb-patches/2021-January/174660.html > > but my test case shows the regression in the partial symbols. > > > > Maybe you can take my test case and merge it to your patch? > > > Thanks > Bernd. > Haha, I also wrote the same patch: https://sourceware.org/pipermail/gdb-patches/2021-January/175225.html Either of your patches is fine with me. Note that the test that I add later in my series (written with the DWARF assembler) triggers the bug as well. Simon