From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oWtbIyZLtWrXeT0AWB0awg (envelope-from ) for ; Thu, 24 Sep 2026 12:09:10 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WP1w1xV/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6Ig/pwmw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fLxzTvom; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DTvuacUx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 67A471E06B; Thu, 24 Sep 2026 12:09:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EE1441E01F for ; Thu, 24 Sep 2026 12:09:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 859FF4BCA41E for ; Thu, 24 Sep 2026 16:09:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 859FF4BCA41E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WP1w1xV/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6Ig/pwmw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fLxzTvom; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DTvuacUx Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id C242B4BB3BE3 for ; Thu, 24 Sep 2026 16:08:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C242B4BB3BE3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C242B4BB3BE3 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790266124; cv=none; b=Zzn54QjkTD5a83d9NEgn+wgd8Unpx8be96Q4vcCLb2pPfh8iop46MyGnvc2C+kJumDiC3lvuye8clBPW+Trf3ejAMeQ/NKVqmL5nK67StE19ogceLf94dlU3N8mFXRU1mEwjXMBgfMkn7/0j7hAAnrQt0jZ7LGucE1ZA6tEl1RQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790266124; c=relaxed/simple; bh=Hhe0QmltegdvPmQMS6W5x+oxWhZ6hsgn+aOtWT7n5Ek=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=Ebe5f1dO4nCNwz436RBXEtg75TAI/C9ZhoKjtk6QwzA9bddbpYQVhuKMuQy8gWhpRqIADUBVlr8ziLMH2rxYBv8zECEoIGKthoEOIZNkFq9FDtiiP4OeiopIihoOv3NwvIOhoWYcFLmKuzcqo8Fa7WqWDSsQ1OpvNrbgFMOJckY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WP1w1xV/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=6Ig/pwmw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fLxzTvom; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DTvuacUx DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C242B4BB3BE3 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3BA4D21FE8; Thu, 24 Sep 2026 16:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790266119; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W264OgqueG4axHqyn0HRunnLbHVrHSkfZspLZGXJsWA=; b=WP1w1xV/Gdr6EphAke7YfKOw7X+zqgFUaGt8qIYtzX7HVdmN49zNhNvpQn6M31Ml4FZpyR KPqOiuoUJHadfELb5g+aMOwj/Lx0L1BY/sGBIyGlwfSAuxf69tJ5NGhdYfbovsHlmqWwut qfw5KfuwZQmDATQ5y/Qmxdw137QpUPY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790266119; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W264OgqueG4axHqyn0HRunnLbHVrHSkfZspLZGXJsWA=; b=6Ig/pwmwRORpiqDEJ1q6sTFkCDn930MmASHRKm19aO52VPH4uxoYZYxFX8CmIEsRzzj4s9 Xw/Ss2rDKZZ5fYBw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fLxzTvom; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=DTvuacUx DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790266115; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W264OgqueG4axHqyn0HRunnLbHVrHSkfZspLZGXJsWA=; b=fLxzTvom3RoDJmy9sateihCBMko/jiSeI7tYHKNyxY9l1tGN0vxXXoExgfKJSAJmC+gjKT 8ymcuv/p1eNEQXoEtHhT0QMXzoaYHnRRJChFQbBD0j47acbqmMoftUoM3em1o3/fmZyy19 ULtGtSFM7kfB/F1aB4cq9Bn758cr7qU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790266115; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W264OgqueG4axHqyn0HRunnLbHVrHSkfZspLZGXJsWA=; b=DTvuacUxWrOt+HRhLrFFPD8zEW4F7sGozkUAG/6MqC0IbFzxySM2c+xgdrFXKdoeAdpoF2 Z1LdowNNLNxYkIAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F207C13354; Thu, 24 Sep 2026 16:08:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zp7cMAJLtWrVXwAAD6G6ig (envelope-from ); Thu, 24 Sep 2026 16:08:34 +0000 Message-ID: <56b49174-1d2b-4cf7-a1c2-43431efb80b6@suse.de> Date: Thu, 24 Sep 2026 18:08:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/11] [gdb/testsuite] Refactor exception handling To: Tom Tromey , Keith Seitz Cc: gdb-patches@sourceware.org References: <20260824135855.1195963-1-tdevries@suse.de> <877bl34e9u.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <877bl34e9u.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3BA4D21FE8 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/2/26 9:57 PM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> Thank you for simplifying this exception handling. I've sent > Keith> a few little nits, but otherwise, this LGTM. > > Keith> Reviewed-By: Keith Seitz > > Thanks for doing that. > > I appreciate this series quite a bit. I don't really get why Tcl came > up with such a convoluted approach to what seems like a pretty normal > thing to want to do; but oh well... anyway aside from the questions I > sent and Keith's comments, I think it all looks good. Thanks both for the reviews, much appreciated. I've pushed all patches now, with the exception of "[PATCH 02/11] [gdb/testsuite] Fix return -level 2 bug in with_test_prefix". The code in this patch got merged into another patch, and the test-case was not all that useful. The new test-case gdb.testsuite/transparent-uplevel.exp covers the tested functionality much better. Thanks, - Tom