From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37233 invoked by alias); 31 Mar 2016 20:37:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37219 invoked by uid 89); 31 Mar 2016 20:37:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=lvalue, it! X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 31 Mar 2016 20:36:59 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 70203E8AF0; Thu, 31 Mar 2016 20:36:58 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2VKavBA016256 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 31 Mar 2016 16:36:58 -0400 From: Keith Seitz Subject: Re: [PATCH v4 09/11] [PR gdb/14441] gdb: convert lvalue reference type check to general reference type check To: Artemiy Volkov , "gdb-patches@sourceware.org ml" References: <1457147955-21871-1-git-send-email-artemiyv@acm.org> <1458593958-25656-1-git-send-email-artemiyv@acm.org> <1458593958-25656-10-git-send-email-artemiyv@acm.org> Message-ID: <56FD8A69.3090207@redhat.com> Date: Thu, 31 Mar 2016 20:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1458593958-25656-10-git-send-email-artemiyv@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00611.txt.bz2 One more (very very) small nit; please repost this single patch for final maintainer review. On 03/21/2016 01:59 PM, Artemiy Volkov wrote: > diff --git a/gdb/valops.c b/gdb/valops.c > index 1f423a0..2f1fca2 100644 > --- a/gdb/valops.c > +++ b/gdb/valops.c [snip] > @@ -1716,7 +1712,7 @@ typecmp (int staticp, int varargs, int nargs, > tt1 = check_typedef (t1[i].type); > tt2 = check_typedef (value_type (t2[i])); > > - if (TYPE_CODE (tt1) == TYPE_CODE_REF > + if ((TYPE_IS_REFERENCE (tt1)) > /* We should be doing hairy argument matching, as below. */ > && (TYPE_CODE (check_typedef (TYPE_TARGET_TYPE (tt1))) > == TYPE_CODE (tt2))) Looks like an extra set of parentheses sneaked in here. Yup, that's it! Keith