From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104347 invoked by alias); 31 Mar 2016 20:24:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104328 invoked by uid 89); 31 Mar 2016 20:24:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=160329, transferring X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 31 Mar 2016 20:24:11 +0000 Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id C5.EF.22441.5478DF65; Thu, 31 Mar 2016 22:23:33 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.77) with Microsoft SMTP Server id 14.3.248.2; Thu, 31 Mar 2016 16:24:02 -0400 Subject: Re: [PATCH] Make ftrace tests work with remote targets To: Pedro Alves , References: <1457040175-24438-1-git-send-email-simon.marchi@ericsson.com> <56FB05C9.8050801@redhat.com> From: Simon Marchi Message-ID: <56FD8762.2030909@ericsson.com> Date: Thu, 31 Mar 2016 20:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56FB05C9.8050801@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00608.txt.bz2 On 16-03-29 06:46 PM, Pedro Alves wrote: > On 03/03/2016 09:22 PM, Simon Marchi wrote: >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -3374,7 +3374,7 @@ proc gdb_compile {source dest type options} { >> # dynamically load one by basename, we must specify rpath. If we >> # are using a remote host, DejaGNU will link to the shared library >> # using a relative path, so again we must specify an rpath. >> - if { $shlib_load || ($shlib_found && [is_remote target]) } { >> + if { $shlib_load || $shlib_found } { > > I think the comment above needs updating. What about: # Because we link with libraries using their basename, we may need # (depending on the platform) to set a special rpath value, to allow # the executable to find the libraries it depends on. >> lappend link_options "additional_flags=-Wl,--out-implib,${name}.a" >> - } elseif [is_remote target] { >> + } else { >> # By default, we do not set the soname. This causes the linker > > Likewise. What about: # Set the soname of the library. This causes the linker on ELF # systems to create the DT_NEEDED entry in the executable referring # to the soname of the library, and not its absolute path. This # (using the absolute path) would be problem when testing on a # remote target. # # In conjunction with setting the soname, we add the special # rpath=$ORIGIN value when building the executable, so that it's # able to find the library in its own directory. >> proc gdb_load_shlibs { args } { >> - if {![is_remote target]} { >> - return >> - } >> + if {[is_remote target]} { >> + foreach file $args { >> + # When the target is remote, we simply send the file to the target. >> + gdb_download [shlib_target_file $file] >> + } >> + } else { >> + foreach from $args { >> + # When the target is native, we copy the files to the test directory >> + # (next to the executable), except if that's already where it is. >> + set to [standard_output_file [file tail $from]] > > I'd think it better to make the gdb_download path work for native > testing as well. WDYT? E.g., make shlib_target_file default to > return the test directory path? If I understand correctly, gdb_download would take a local file path and take care of transferring that file to the "runtime test directory", whether it's local or remote. If the target is local, it checks whether $src == $dest, and copies the file if not. Basically, the same as my implementation of gdb_load_shlibs, just not limited to shlibs. I am not sure if "make shlib_target_file default to return the test directory path?" would be ok. I think it's meant to return the local file path to download to the target. So gdb_load_shlibs would then become: proc gdb_load_shlibs { args } { foreach file $args { gdb_download [shlib_target_file $file] } } I just tested it quickly and it seems to work fine. But I also noticed that there might be some overlap in feature between gdb_download and gdb_remote_download, so perhaps I can try to merge them, WDYT? >> # Even if the target supplies full paths for shared libraries, >> # they may not be paths for this system. >> gdb_test "set solib-search-path [file dirname [lindex $args 0]]" "" "" > > Can we skip this command on native testing? > > I'm worried that that command might paper over, or cause, issues with > sysroot / dso path lookup. Normal native debugging usage will not specify > that command, so if we could avoid it, I'd prefer it, on grounds of > testing what users normally use. Makes sense. I'll add that, with a comment explaining why. Thanks! Simon