From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55003 invoked by alias); 31 Mar 2016 17:45:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54523 invoked by uid 89); 31 Mar 2016 17:45:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=par X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 31 Mar 2016 17:45:49 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id D1.62.30335.F5C5DF65; Thu, 31 Mar 2016 19:20:31 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.248.2; Thu, 31 Mar 2016 13:45:46 -0400 Subject: Re: [PATCH 1/2] Fix write endianness/size problem for fast tracepoint enabled flag To: Yao Qi References: <1459351018-23718-1-git-send-email-simon.marchi@ericsson.com> <86oa9urkcm.fsf@gmail.com> CC: , Par Olsson From: Simon Marchi Message-ID: <56FD624A.20800@ericsson.com> Date: Thu, 31 Mar 2016 17:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <86oa9urkcm.fsf@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00602.txt.bz2 On 16-03-31 06:51 AM, Yao Qi wrote: > Simon Marchi writes: > >> I am sending this fix on behalf of Par Olsson, as a follow-up of this >> one: >> >> https://www.sourceware.org/ml/gdb-patches/2015-10/msg00196.html > > Hi Simon, > The patch in the url above is to change 'enabled' field to uint32_t, so > I guess you got the patch below from Par Olsson off list? > > The reason I ask this is that I find the author doesn't have the copyright > assignment. We can take it as a tiny patch, if no one has objections. Par indeed sent us this off-list. But as Pedro mentioned, Wind River is covered. > >> static int >> +write_inferior_int8 (CORE_ADDR symaddr, int8_t val) >> +{ >> + return write_inferior_memory (symaddr, (unsigned char *) &val, sizeof (val)); > > This line is too long. It's 79 characters long, no? It's the same line as the line in write_inferior_integer, I think they are both ok. > The patch itself is good to me. Ok thanks, I'll push it when the corresponding test is accepted.