Re: [PATCH 3/4 v2] gdbserver: Add powerpc fast tracepoint support.

Ulrich Weigand
2016-03-17T06:30:53Z

Marcin KoÃ…Â›cielnicki wrote:
> On 16/03/16 17:58, Ulrich Weigand wrote:
> > Was there a particular reason why you changed to using direct ptrace
> > calls instead of collecting the value from the regcache as in the
> > original patch?
>
> Not really, I just happened to had this bit written before I learned of
> Wei-cheng's patches. What are your preferences here?

I think using collect_register_by_name is probably better. Then you
also shouldn't need to do this:

+#ifdef __powerpc64__
+ if (!is_64)
+ *addr &= 0xffffffffull;
+#endif

because that should be handled automatically by the regcache logic.

Bye,
Ulrich

--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com