From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121936 invoked by alias); 30 Mar 2016 15:28:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121902 invoked by uid 89); 30 Mar 2016 15:28:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1595, H*MI:sk:56FBEFA, H*i:sk:56FBEFA, H*f:sk:56FBEFA X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 30 Mar 2016 15:28:08 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 0D.C5.30335.7AAEBF65; Wed, 30 Mar 2016 17:03:04 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.248.2; Wed, 30 Mar 2016 11:28:04 -0400 Subject: Re: [PATCH v2 3/4] gdbserver: Add powerpc fast tracepoint support. To: Ulrich Weigand References: <20160330145738.CB3D24989@oc7340732750.ibm.com> <56FBEFA6.5090301@ericsson.com> CC: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= , From: Simon Marchi Message-ID: <56FBF085.60106@ericsson.com> Date: Wed, 30 Mar 2016 15:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56FBEFA6.5090301@ericsson.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00573.txt.bz2 On 16-03-30 11:24 AM, Simon Marchi wrote: > On 16-03-30 10:57 AM, Ulrich Weigand wrote: >> Hi Marcin, >> >>> This gives me an error when building on the gcc compile farm machine gc= c110. >>> I just applied your patches on today's master. >> >>> linux-ppc-low.c: In function 'is_elfv2_inferior': >>> linux-ppc-low.c:774:26: error: 'EF_PPC64_ABI' undeclared (f=3D >>> irst use in this function) >>> return (ehdr.e_flags & EF_PPC64_ABI) =3D=3D 2; >> >> You probably should add >> >> #include "elf/ppc64.h" >> >> to make sure you always got the latest defines from the in-tree >> BFD headers, and not the (possibly outdated) system headers. >> >> Bye, >> Ulrich >=20 > I now get this: >=20 > In file included from ./../../include/elf/ppc64.h:24:0, > from linux-ppc-low.c:30: > ./../../include/elf/ppc64.h:28:17: error: expected identifier before nume= ric constant > RELOC_NUMBER (R_PPC64_NONE, 0) > ^ > ./../../include/elf/reloc-macros.h:122:37: note: in definition of macro = =91RELOC_NUMBER=92 > #define RELOC_NUMBER(name, number) name =3D number, > ^ > In file included from linux-ppc-low.c:30:0: > ./../../include/elf/ppc64.h:240:0: error: "DT_PPC64_GLINK" redefined [-We= rror] > #define DT_PPC64_GLINK DT_LOPROC > ^ > In file included from linux-ppc-low.c:23:0: > /usr/include/elf.h:2264:0: note: this is the location of the previous def= inition > #define DT_PPC64_GLINK (DT_LOPROC + 0) > ^ >=20 > Simon Ahh, it seems like the ordering is important here. If I include it before = (and everything that includes ), it works. Thanks, Simon