From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108009 invoked by alias); 29 Mar 2016 23:51:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107995 invoked by uid 89); 29 Mar 2016 23:51:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,KAM_ADVERT2,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (159.100.250.38) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Mar 2016 23:51:36 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 133871A3C0; Tue, 29 Mar 2016 23:51:34 +0000 (UTC) Received: from [172.21.36.130] (unknown [88.214.186.105]) by hogfather.0x04.net (Postfix) with ESMTPSA id CED085800EF; Wed, 30 Mar 2016 01:51:33 +0200 (CEST) Subject: Re: [PATCH] gdbserver: Handle 'v' packet while processing qSymbol. To: Pedro Alves , gdb-patches@sourceware.org References: <1457794943-12954-1-git-send-email-koriakin@0x04.net> <56FAFB0A.4070602@redhat.com> From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56FB1504.6070202@0x04.net> Date: Tue, 29 Mar 2016 23:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <56FAFB0A.4070602@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00547.txt.bz2 On 30/03/16 00:00, Pedro Alves wrote: > On 03/12/2016 03:02 PM, Marcin Kościelnicki wrote: > >> gdb/ChangeLog | 5 +++++ >> gdb/gdbserver/ChangeLog | 10 ++++++++++ >> gdb/gdbserver/remote-utils.c | 41 +++++++++++++++++++++++++++-------------- >> gdb/gdbserver/server.c | 4 ++-- >> gdb/gdbserver/server.h | 4 ++++ >> gdb/remote.c | 22 +++++++++++++++++----- >> 6 files changed, 65 insertions(+), 21 deletions(-) >> >> diff --git a/gdb/ChangeLog b/gdb/ChangeLog >> index febe960..41f826e 100644 >> --- a/gdb/ChangeLog >> +++ b/gdb/ChangeLog >> @@ -1,3 +1,8 @@ >> +2016-03-12 Marcin Kościelnicki >> + >> + * remote.c (xfreep): New function. > > You can use free_current_contents instead. Whoops, I should've guessed there's something like that already... > >> + (remote_check_symbols): Allocate own buffer for reply. >> + > >> @@ -1499,21 +1499,35 @@ look_up_one_symbol (const char *name, CORE_ADDR *addrp, int may_ask_gdb) >> main loop. For now, this is an adequate approximation; allow >> GDB to read from memory while it figures out the address of the >> symbol. */ >> - while (own_buf[0] == 'm') >> + while (1) > > Comment above is stale. > > OK with those addressed. Thanks, fixed and pushed. > > Thanks, > Pedro Alves >