From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111016 invoked by alias); 29 Mar 2016 22:46:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110996 invoked by uid 89); 29 Mar 2016 22:46:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1927, grounds, paper, Normal X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 29 Mar 2016 22:46:36 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 4DA4E64379; Tue, 29 Mar 2016 22:46:35 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2TMkXMC004533; Tue, 29 Mar 2016 18:46:34 -0400 Subject: Re: [PATCH] Make ftrace tests work with remote targets To: Simon Marchi , gdb-patches@sourceware.org References: <1457040175-24438-1-git-send-email-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <56FB05C9.8050801@redhat.com> Date: Tue, 29 Mar 2016 22:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1457040175-24438-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00544.txt.bz2 On 03/03/2016 09:22 PM, Simon Marchi wrote: > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -3374,7 +3374,7 @@ proc gdb_compile {source dest type options} { > # dynamically load one by basename, we must specify rpath. If we > # are using a remote host, DejaGNU will link to the shared library > # using a relative path, so again we must specify an rpath. > - if { $shlib_load || ($shlib_found && [is_remote target]) } { > + if { $shlib_load || $shlib_found } { I think the comment above needs updating. > lappend link_options "additional_flags=-Wl,--out-implib,${name}.a" > - } elseif [is_remote target] { > + } else { > # By default, we do not set the soname. This causes the linker Likewise. > proc gdb_load_shlibs { args } { > - if {![is_remote target]} { > - return > - } > + if {[is_remote target]} { > + foreach file $args { > + # When the target is remote, we simply send the file to the target. > + gdb_download [shlib_target_file $file] > + } > + } else { > + foreach from $args { > + # When the target is native, we copy the files to the test directory > + # (next to the executable), except if that's already where it is. > + set to [standard_output_file [file tail $from]] I'd think it better to make the gdb_download path work for native testing as well. WDYT? E.g., make shlib_target_file default to return the test directory path? > # Even if the target supplies full paths for shared libraries, > # they may not be paths for this system. > gdb_test "set solib-search-path [file dirname [lindex $args 0]]" "" "" Can we skip this command on native testing? I'm worried that that command might paper over, or cause, issues with sysroot / dso path lookup. Normal native debugging usage will not specify that command, so if we could avoid it, I'd prefer it, on grounds of testing what users normally use. Thanks, Pedro Alves