From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-130547-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11230 invoked by alias); 29 Mar 2016 19:09:36 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 11217 invoked by uid 89); 29 Mar 2016 19:09:35 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:1459275, H*MI:sk:1459275, longest
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 29 Mar 2016 19:09:34 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (Postfix) with ESMTPS id AE2DF64443;	Tue, 29 Mar 2016 19:09:33 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2TJ9USB001083;	Tue, 29 Mar 2016 15:09:31 -0400
Subject: Re: [PATCH v2] gdb: xtensa: fix frame initialization when PC is invalid
To: Max Filippov <jcmvbkbc@gmail.com>, gdb-patches@sourceware.org
References: <1459275473-11718-1-git-send-email-jcmvbkbc@gmail.com>
Cc: Maxim Grigoriev <maxim2405@gmail.com>, Woody LaRue <larue@cadence.com>,        Marc Gauthier <marc@cadence.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <56FAD2EA.50003@redhat.com>
Date: Tue, 29 Mar 2016 19:09:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <1459275473-11718-1-git-send-email-jcmvbkbc@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-03/txt/msg00533.txt.bz2

On 03/29/2016 07:17 PM, Max Filippov wrote:
> -      op1 = read_memory_integer (pc, 1, byte_order);
> -      if (XTENSA_IS_ENTRY (gdbarch, op1))
> +      if (safe_read_memory_integer (pc, 1, byte_order, &op1)
> +	  && XTENSA_IS_ENTRY (gdbarch, op1))
>   	{

I'm surprised if this compiles without an "incompatible pointer type"
warning/error?  safe_read_memory_integer's last parameter is
'LONGEST *', while op1 is 'char', AFAICS.  So you need to change op1
to be a LONGEST to match.

Thanks,
Pedro Alves