From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-130444-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 48272 invoked by alias); 21 Mar 2016 19:48:43 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 48262 invoked by uid 89); 21 Mar 2016 19:48:42 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:339, nit
X-HELO: usplmg20.ericsson.net
Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 21 Mar 2016 19:48:41 +0000
Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78])	by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id F0.62.30335.6AA40F65; Mon, 21 Mar 2016 20:25:27 +0100 (CET)
Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.80) with Microsoft SMTP Server id 14.3.248.2; Mon, 21 Mar 2016 15:48:38 -0400
Subject: Re: [PATCH 09/30] Introduce interruptible_select
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
References: <1458328714-4938-1-git-send-email-palves@redhat.com> <1458328714-4938-10-git-send-email-palves@redhat.com>
From: Simon Marchi <simon.marchi@ericsson.com>
Message-ID: <56F05016.3000307@ericsson.com>
Date: Mon, 21 Mar 2016 19:48:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1458328714-4938-10-git-send-email-palves@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2016-03/txt/msg00430.txt.bz2

On 16-03-18 03:18 PM, Pedro Alves wrote:
> +int
> +interruptible_select (int n,
> +		      fd_set *readfds, fd_set *writefds, fd_set *exceptfds,
> +		      struct timeval *timeout)
> +{
> +  fd_set my_readfds;
> +  int fd;

Just a nit.  For clarity, you could name this variable "quit_fd" instead of "fd".