From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87214 invoked by alias); 21 Mar 2016 18:33:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87200 invoked by uid 89); 21 Mar 2016 18:33:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1141 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 21 Mar 2016 18:33:36 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 2787180E4A; Mon, 21 Mar 2016 18:33:35 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2LIXXp7000566; Mon, 21 Mar 2016 14:33:34 -0400 Subject: Re: [PATCH 09/30] Introduce interruptible_select To: Simon Marchi , gdb-patches@sourceware.org References: <1458328714-4938-1-git-send-email-palves@redhat.com> <1458328714-4938-10-git-send-email-palves@redhat.com> <56F0367A.5000702@ericsson.com> From: Pedro Alves Message-ID: <56F03E7D.7080105@redhat.com> Date: Mon, 21 Mar 2016 18:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56F0367A.5000702@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00425.txt.bz2 On 03/21/2016 05:59 PM, Simon Marchi wrote: > On 16-03-18 03:18 PM, Pedro Alves wrote: >> @@ -749,6 +757,8 @@ async_init_signals (void) >> { >> initialize_async_signal_handlers (); >> >> + quit_serial_event = make_serial_event (); >> + > > Just above these line is this comment: > > /* NOTE: 1999-04-30 This is the asynchronous version of init_signals. > init_signals will become obsolete as we move to have to event loop > as the default for gdb. */ > > > Is is still relevant? That comment is stale since (I think): 2004-09-13 Andrew Cagney ... Eliminate event_loop_p, always has the value 1. * defs.h (event_loop_p): Delete macro. * breakpoint.c (until_break_command): Simplify. * utils.c (prompt_for_continue): Simplify. * tracepoint.c (read_actions): Simplify. * top.c (throw_exception, execute_command, gdb_readline_wrapper) (gdb_rl_operate_and_get_next, command_line_input, get_prompt) (set_prompt, init_main): Simplify. (init_signals, disconnect): Delete, unused. That is, init_signals is long gone, and we always have an event loop running. Thanks, Pedro Alves