[PATCH 12/30] Don't call clear_quit_flag in command_handler

Pedro Alves
2016-03-18T19:25:04Z

This just looks totally wrong to me, for completetly discarding a
user-requested Ctrl-C. I can't think of why we'd want do this here.

Actually, I digged the history, and found out that this has been here
since at least 7b4ac7e1ed2c (gdb-2.4, the initial revision, 1988), at
a time were we had a top level setjmp/longjmp, long before that got
wrapped in throw_exception and friends, and this code was in an
explicit loop, with the quit_flag cleared on every iteration, before
executing a command...

gdb/ChangeLog:
yyyy-mm-dd Pedro Alves <palves@redhat.com>

* event-top.c (command_handler): Don't call clear_quit_flag.
---
gdb/event-top.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/gdb/event-top.c b/gdb/event-top.c
index da72b1d..7fedb48 100644
--- a/gdb/event-top.c
+++ b/gdb/event-top.c
@@ -459,7 +459,6 @@ command_handler (char *command)
struct cleanup *stat_chain;
char *c;

- clear_quit_flag ();
if (instream == stdin)
reinitialize_more_filter ();

--
2.5.0