Re: [PATCH 09/30] Introduce interruptible_select

Pedro Alves
2016-03-21T18:33:47Z

On 03/21/2016 05:59 PM, Simon Marchi wrote:
> On 16-03-18 03:18 PM, Pedro Alves wrote:
>> @@ -749,6 +757,8 @@ async_init_signals (void)
>> {
>> initialize_async_signal_handlers ();
>>
>> + quit_serial_event = make_serial_event ();
>> +
>
> Just above these line is this comment:
>
> /* NOTE: 1999-04-30 This is the asynchronous version of init_signals.
> init_signals will become obsolete as we move to have to event loop
> as the default for gdb. */
>
>
> Is is still relevant?

That comment is stale since (I think):

2004-09-13 Andrew Cagney <cagney@gnu.org>
...
Eliminate event_loop_p, always has the value 1.
* defs.h (event_loop_p): Delete macro.
* breakpoint.c (until_break_command): Simplify.
* utils.c (prompt_for_continue): Simplify.
* tracepoint.c (read_actions): Simplify.
* top.c (throw_exception, execute_command, gdb_readline_wrapper)
(gdb_rl_operate_and_get_next, command_line_input, get_prompt)
(set_prompt, init_main): Simplify.
(init_signals, disconnect): Delete, unused.

That is, init_signals is long gone, and we always have an event loop
running.

Thanks,
Pedro Alves