From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97619 invoked by alias); 18 Mar 2016 14:26:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97607 invoked by uid 89); 18 Mar 2016 14:26:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 18 Mar 2016 14:26:38 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 0716780500 for ; Fri, 18 Mar 2016 14:26:37 +0000 (UTC) Received: from [10.36.5.23] (vpn1-5-23.ams2.redhat.com [10.36.5.23]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2IEQZGa010057 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 18 Mar 2016 10:26:36 -0400 Subject: Re: Commit: AArch64: Simulate scalar NEG and vector MUL To: gdb-patches@sourceware.org References: <87io0kt9lt.fsf@redhat.com> <20160318132718.GF6588@vapier.lan> From: Nick Clifton Message-ID: <56EC101B.1060709@redhat.com> Date: Fri, 18 Mar 2016 14:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160318132718.GF6588@vapier.lan> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00332.txt.bz2 Hi Mike, >> +#define GET_VEC_ELEMENT(REG, ELEMENT, FIELD) \ > is using all caps for arg names a normal style thing ? For macros, yes. For example, in gdb/gdbarch.h: #define GDBARCH_OBSTACK_CALLOC(GDBARCH, NR, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), (NR) * sizeof (TYPE))) >> + if (element > ARRAY_SIZE (cpu->fr[0].FIELD)) \ > shouldn't this be ELEMENT ? and be >= ? Yes. >> + if (ELEMENT > ARRAY_SIZE (cpu->fr[0].FIELD)) \ Yup. Patch coming. Cheers Nick