From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111475 invoked by alias); 17 Mar 2016 11:07:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111464 invoked by uid 89); 17 Mar 2016 11:07:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 17 Mar 2016 11:07:44 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 41D81C03BD54; Thu, 17 Mar 2016 11:07:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2HB7fr4005757; Thu, 17 Mar 2016 07:07:42 -0400 Subject: Re: [PATCH 2/8] Check LWP_SIGNAL_CAN_BE_DELIVERED for enqueue/dequeue pending signals To: Yao Qi References: <1457088276-1170-1-git-send-email-yao.qi@linaro.org> <1457088276-1170-3-git-send-email-yao.qi@linaro.org> <56E2A42E.4080308@redhat.com> <86a8lxxzsu.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <56EA8FFD.1040708@redhat.com> Date: Thu, 17 Mar 2016 11:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <86a8lxxzsu.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00306.txt.bz2 On 03/17/2016 08:40 AM, Yao Qi wrote: > > Here is the version to change it to function and also update comments as > Luis suggested. Thanks. > +/* The signal can be delivered to the inferior if we are not trying to > + reinsert a breakpoint and not trying to finish a fast tracepoint > + collect. */ > + > +static int > +lwp_signal_can_be_delivered (struct lwp_info *lwp) > +{ > + return !(lwp->bp_reinsert != 0 || lwp->collecting_fast_tracepoint); The comment is written in terms of "and", but the implementation is in terms of "or", negated. If you write it like: return (lwp->bp_reinsert == 0 && !lwp->collecting_fast_tracepoint); then it matches exactly what the comment says, making it easier to reason about. Otherwise LGTM. Thanks, Pedro Alves