From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43723 invoked by alias); 16 Mar 2016 22:26:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43699 invoked by uid 89); 16 Mar 2016 22:26:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Mar 2016 22:26:11 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id DF973219E; Wed, 16 Mar 2016 22:26:09 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2GMQ9oB015201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Mar 2016 18:26:09 -0400 Subject: Re: [PATCH v3 06/11] [PR gdb/14441] gdb: print: implement correct printing of rvalue reference types and values To: Artemiy Volkov , gdb-patches@sourceware.org References: <1453229609-20159-1-git-send-email-artemiyv@acm.org> <1457147955-21871-1-git-send-email-artemiyv@acm.org> <1457147955-21871-7-git-send-email-artemiyv@acm.org> From: Keith Seitz Message-ID: <56E9DD81.5020900@redhat.com> Date: Wed, 16 Mar 2016 22:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1457147955-21871-7-git-send-email-artemiyv@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00276.txt.bz2 On 03/04/2016 07:19 PM, Artemiy Volkov wrote: > This patch provides the ability to print out names of rvalue reference types > and values of those types. This is done in full similarity to regular > references, and as with them, we don't print out "const" suffix because all > rvalue references are const. > > gdb/ChangeLog: > > 2016-03-04 Artemiy Volkov > > * c-typeprint.c (c_print_type, c_type_print_varspec_prefix) > (c_type_print_modifier, c_type_print_varspec_suffix) > (c_type_print_base): Support printing rvalue reference types. > * c-valprint.c (c_val_print, c_value_print): Support printing > rvalue reference values. > --- > gdb/c-typeprint.c | 10 ++++++---- > gdb/c-valprint.c | 4 ++-- > 2 files changed, 8 insertions(+), 6 deletions(-) This looks okay, too. Keith