From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34854 invoked by alias); 16 Mar 2016 22:22:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34755 invoked by uid 89); 16 Mar 2016 22:22:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Mar 2016 22:22:19 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 2C4AB20A9A; Wed, 16 Mar 2016 22:22:18 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2GMMHUK029355 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Mar 2016 18:22:17 -0400 From: Keith Seitz Subject: Re: [PATCH v3 03/11] [PR gdb/14441] gdb: valops: add ability to return rvalue reference values from value_ref() To: Artemiy Volkov , gdb-patches@sourceware.org References: <1453229609-20159-1-git-send-email-artemiyv@acm.org> <1457147955-21871-1-git-send-email-artemiyv@acm.org> <1457147955-21871-4-git-send-email-artemiyv@acm.org> Message-ID: <56E9DC99.8010702@redhat.com> Date: Wed, 16 Mar 2016 22:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1457147955-21871-4-git-send-email-artemiyv@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00273.txt.bz2 On 03/04/2016 07:19 PM, Artemiy Volkov wrote: > diff --git a/gdb/c-valprint.c b/gdb/c-valprint.c > index 62552ec..a1f5db6 100644 > --- a/gdb/c-valprint.c > +++ b/gdb/c-valprint.c > @@ -602,10 +602,13 @@ c_value_print (struct value *val, struct ui_file *stream, > else if (options->objectprint > && (TYPE_CODE (TYPE_TARGET_TYPE (type)) == TYPE_CODE_STRUCT)) > { > - int is_ref = TYPE_CODE (type) == TYPE_CODE_REF; > + int is_ref = TYPE_IS_REFERENCE (type); > + enum type_code refcode = TYPE_CODE_UNDEF; > > - if (is_ref) > + if (is_ref) { > val = value_addr (val); > + refcode = TYPE_CODE (type); > + } > Open braces go on new line. > /* Pointer to class, check real type of object. */ > fprintf_filtered (stream, "("); Keith