From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5926 invoked by alias); 16 Mar 2016 22:08:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5916 invoked by uid 89); 16 Mar 2016 22:08:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=harvard, Harvard X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Mar 2016 22:07:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id C762870AA8; Wed, 16 Mar 2016 22:07:57 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2GM7ufI022288 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Mar 2016 18:07:57 -0400 Subject: Re: [PATCH v3 01/11] [PR gdb/14441] gdb: gdbtypes: add definitions for rvalue reference type To: Artemiy Volkov , gdb-patches@sourceware.org References: <1453229609-20159-1-git-send-email-artemiyv@acm.org> <1457147955-21871-1-git-send-email-artemiyv@acm.org> <1457147955-21871-2-git-send-email-artemiyv@acm.org> From: Keith Seitz Message-ID: <56E9D93C.9000206@redhat.com> Date: Wed, 16 Mar 2016 22:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1457147955-21871-2-git-send-email-artemiyv@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00270.txt.bz2 On 03/04/2016 07:19 PM, Artemiy Volkov wrote: > diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h > index e775a1d..3bdbcd9 100644 > --- a/gdb/gdbtypes.h > +++ b/gdb/gdbtypes.h > @@ -362,6 +364,11 @@ enum type_instance_flag_value > #define TYPE_ATOMIC(t) \ > (TYPE_INSTANCE_FLAGS (t) & TYPE_INSTANCE_FLAG_ATOMIC) > > +/* True if this type represents either an lvalue or lvalue reference type. */ > + I think there's a missing '*' docbook marker on this comment. [Arguably, that whole thing appears to have fallen by the wayside...] > +#define TYPE_IS_REFERENCE(t) \ > + (TYPE_CODE (t) == TYPE_CODE_REF || TYPE_CODE (t) == TYPE_CODE_RVALUE_REF) > + > /* * Instruction-space delimited type. This is for Harvard architectures > which have separate instruction and data address spaces (and perhaps > others). Otherwise looks good. Keith