From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90246 invoked by alias); 15 Mar 2016 17:51:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90224 invoked by uid 89); 15 Mar 2016 17:51:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=feels, palves, Hx-languages-length:1136 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Mar 2016 17:51:06 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 5748B627C3; Tue, 15 Mar 2016 17:51:05 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2FHp4PZ005788; Tue, 15 Mar 2016 13:51:04 -0400 Subject: Re: [PING][PATCH] Python: Fix Python error when "Quit"ting a paged info pretty-printers To: Tom Tromey , Leonardo Boquillon References: <1458046365-21110-1-git-send-email-leonardo.boquillon@tallertechnologies.com> <87bn6flkt9.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <56E84B87.5020100@redhat.com> Date: Tue, 15 Mar 2016 17:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <87bn6flkt9.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00241.txt.bz2 On 03/15/2016 05:20 PM, Tom Tromey wrote: > Leonardo> Right now the "Quit" command used in the output paging is > Leonardo> handled as an exception. If we issue a "Quit" while > Leonardo> outputting the registered pretty-printers list, the Python > Leonardo> handling layer will catch it and think it's a Python error. > > Leonardo> The fix is to check if the error coming from Python is a Quit > Leonardo> signal. If it is, do not handle it as an error and resume the > Leonardo> execution normally. > > I think a quit should be turned into a PyExc_KeyboardInterrupt. So it > would make sense, IMO, to turn a PyExc_KeyboardInterrupt back into a > RETURN_QUIT in py-cmd.c. That makes sense to me. We already do something like that, in set_active_ext_lang / restore_active_ext_lang, actually. ( I happen to be working on getting rid of immediate_quit, for C++ conversion, and a good part of that is about not losing Ctrl-C's, ever, so that feels quite apropos: https://github.com/palves/gdb/commits/palves/immediate_quit ) Thanks, Pedro Alves