From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75287 invoked by alias); 15 Mar 2016 15:55:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75277 invoked by uid 89); 15 Mar 2016 15:55:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=sk:checkpo, UD:checkpoint-ns.exp X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Mar 2016 15:55:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 3B61834157A; Tue, 15 Mar 2016 15:55:08 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2FFt6fT020403; Tue, 15 Mar 2016 11:55:06 -0400 Subject: Re: [PING] Re: [PATCH v4] PR 18303, Tolerate malformed input for lookup_symbol-called functions To: Don Breazeal , Keith Seitz , Doug Evans References: <1454021528-7073-1-git-send-email-donb@codesourcery.com> <56B39A52.9010203@codesourcery.com> <56C609E5.3060506@codesourcery.com> <56CF3992.7000200@codesourcery.com> <56D88019.7040105@codesourcery.com> <56E72BCE.8090701@codesourcery.com> From: Pedro Alves Cc: gdb-patches@sourceware.org Message-ID: <56E8305A.2000404@redhat.com> Date: Tue, 15 Mar 2016 15:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E72BCE.8090701@codesourcery.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00236.txt.bz2 On 03/14/2016 09:23 PM, Don Breazeal wrote: > On 1/28/2016 4:06 AM, Pedro Alves wrote: >> On 01/28/2016 01:21 AM, Don Breazeal wrote: >>> The patch includes three new tests related to this. One is just >>> gdb.linespec/ls-errs.exp copied and converted to use C++ instead of > C, and >>> to add a case using a file name containing a Windows-style logical drive >>> specifier. >> .... >>> gdb/testsuite/gdb.linespec/ls-errs-cp.cc | 36 +++++ >>> gdb/testsuite/gdb.linespec/ls-errs-cp.exp | 240 > ++++++++++++++++++++++++++++ >> ... >> >> Can't we somehow reuse the existing test? Say, either: >> >> - move the main body of ls-errs.exp a procedure, and call it twice, >> once for each language, or, >> >> - make gdb.linespec/ls-errs-cp.exp set some $language var and then >> source gdb.linespec/ls-errs.exp, like gdb.base/checkpoint-ns.exp. >> >> Thanks, >> Pedro Alves >> > > Hi Pedro, > I used your first suggestion above. Did you have any other comments > for this one, or is it good to go? Sorry, that was really only a generic passer-by comment. I'd rather leave it to Doug or Keith to approve. On the testcase part, it may help to post a "git diff -w" patch, so we can see the real differences without all the reindentation churn. Thanks, Pedro Alves