From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14626 invoked by alias); 15 Mar 2016 11:30:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13955 invoked by uid 89); 15 Mar 2016 11:30:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2106 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Mar 2016 11:30:39 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 4A198C049D67; Tue, 15 Mar 2016 11:30:28 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2FBUQNA020256; Tue, 15 Mar 2016 07:30:26 -0400 Subject: Re: [PATCH 4/8] gdb/s390: Fill gen_return_address hook. To: Andreas Arnez References: <1453637529-26972-5-git-send-email-koriakin@0x04.net> <1454853751-18455-1-git-send-email-koriakin@0x04.net> <56E2AD82.3060101@0x04.net> <56E2B95F.7050701@0x04.net> <56E2E7C8.7050901@redhat.com> <56E2FA1B.7050808@redhat.com> <83shzwj2wt.fsf@gnu.org> <56E31062.7020707@redhat.com> <83h9gcizcb.fsf@gnu.org> <56E7EDCC.8040400@redhat.com> Cc: Eli Zaretskii , koriakin@0x04.net, gdb-patches@sourceware.org From: Pedro Alves Message-ID: <56E7F252.9010903@redhat.com> Date: Tue, 15 Mar 2016 11:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-03/txt/msg00229.txt.bz2 On 03/15/2016 11:23 AM, Andreas Arnez wrote: > On Tue, Mar 15 2016, Pedro Alves wrote: > >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> index bf7df35..5f88335 100644 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -12878,6 +12878,13 @@ Collect all local variables. >> Collect the return address. This is helpful if you want to see more >> of a backtrace. >> >> +@emph{Note:} The return address location can not always be reliability > ^^^^^^^^^^^ > Should be "reliably" ;-) Bah. I knew I'd forget something... Thanks for double checking. Fixed with the patch below. >From 2a60e18f8fe3bf9512671e02b39acacb484bb8c6 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Tue, 15 Mar 2016 11:29:03 +0000 Subject: [PATCH] Fix typo in previous gdb/doc/ commit Should be s/reliability/reliably/. gdb/doc/ChangeLog: 2016-03-15 Pedro Alves * gdb.texinfo (Tracepoint Actions): Fix typo. --- gdb/doc/ChangeLog | 4 ++++ gdb/doc/gdb.texinfo | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 0606d9d..a48d1c4 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,4 +1,8 @@ 2016-03-15 Pedro Alves + + * gdb.texinfo (Tracepoint Actions): Fix typo. + +2016-03-15 Pedro Alves Andreas Arnez Marcin Kościelnicki diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 5f88335..71657b0 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -12878,7 +12878,7 @@ Collect all local variables. Collect the return address. This is helpful if you want to see more of a backtrace. -@emph{Note:} The return address location can not always be reliability +@emph{Note:} The return address location can not always be reliably determined up front, and the wrong address / registers may end up collected instead. On some architectures the reliability is higher for tracepoints at function entry, while on others it's the opposite. -- 2.5.0