From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44373 invoked by alias); 11 Mar 2016 10:55:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44361 invoked by uid 89); 11 Mar 2016 10:55:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 11 Mar 2016 10:55:44 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 5DE4864D1D; Fri, 11 Mar 2016 10:55:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2BAtgcm027246; Fri, 11 Mar 2016 05:55:42 -0500 Subject: Re: [PATCH 2/8] Check LWP_SIGNAL_CAN_BE_DELIVERED for enqueue/dequeue pending signals To: Yao Qi , gdb-patches@sourceware.org References: <1457088276-1170-1-git-send-email-yao.qi@linaro.org> <1457088276-1170-3-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <56E2A42E.4080308@redhat.com> Date: Fri, 11 Mar 2016 10:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457088276-1170-3-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00177.txt.bz2 On 03/04/2016 10:44 AM, Yao Qi wrote: > The enqueue and dequeue signals in linux_resume_one_lwp_throw use one > condition and its inverted one. This patch is to move the condition > into a macro LWP_SIGNAL_CAN_BE_DELIVERED, so that the next patch can > change the condition in one place. I like the idea, but why a macro instead of a function? Thanks, Pedro Alves