From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42010 invoked by alias); 11 Mar 2016 10:53:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41997 invoked by uid 89); 11 Mar 2016 10:53:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1519, enqueue, Today X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 11 Mar 2016 10:53:42 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 06FC785543; Fri, 11 Mar 2016 10:53:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2BArd2H005746; Fri, 11 Mar 2016 05:53:40 -0500 Subject: Re: [PATCH 1/8] Set signal to 0 after enqueue_pending_signal To: Yao Qi , gdb-patches@sourceware.org References: <1457088276-1170-1-git-send-email-yao.qi@linaro.org> <1457088276-1170-2-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <56E2A3B3.8010303@redhat.com> Date: Fri, 11 Mar 2016 10:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457088276-1170-2-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00176.txt.bz2 On 03/04/2016 10:44 AM, Yao Qi wrote: > Today, we enqueue signal in linux_resume_one_lwp_throw, but set > variable 'signal' many lines below with the comment > > /* Postpone any pending signal. It was enqueued above. */ > signal = 0; > > I feel difficult to associate code across many lines, and we should > move the code close to enqueue_pending_signal call. This is what > this patch does in general. After this change, variable 'signal' > is set to zero very early, so the 'signal' value in the following > debugging message makes no sense, so I remove it from the debugging > message. The function returns early if lwp->status_pending_p is > true, so 'signal' value in the debugging message doesn't matter, > AFAICS. Also, I move one debugging message several lines below to > make it close the real ptrace call, > > if (debug_threads) > debug_printf ("Resuming lwp %ld (%s, signal %d, stop %s)\n", > lwpid_of (thread), step ? "step" : "continue", signal, > lwp->stop_expected ? "expected" : "not expected"); > > so that the debugging message can reflect what GDBserver does. This > is a code refactor and only debugging messages are affected. > > gdb/gdbserver: > > 2016-03-04 Yao Qi > > * linux-low.c (linux_resume_one_lwp_throw): Set 'signal' to > 0 if signal is enqueued. Remove 'signal' from one debugging > message. Move one debugging message to some lines below. > Remove code setting 'signal' to 0. OK. Thanks, Pedro Alves