Re: [PATCH 4/8] gdb/s390: Fill gen_return_address hook.

Pedro Alves
2016-03-15T11:30:53Z

On 03/15/2016 11:23 AM, Andreas Arnez wrote:
> On Tue, Mar 15 2016, Pedro Alves wrote:
>
>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>> index bf7df35..5f88335 100644
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -12878,6 +12878,13 @@ Collect all local variables.
>> Collect the return address. This is helpful if you want to see more
>> of a backtrace.
>>
>> +@emph{Note:} The return address location can not always be reliability
> ^^^^^^^^^^^
> Should be "reliably" ;-)

Bah. I knew I'd forget something... Thanks for double checking.

Fixed with the patch below.

From 2a60e18f8fe3bf9512671e02b39acacb484bb8c6 Mon Sep 17 00:00:00 2001
From: Pedro Alves <palves@redhat.com>
Date: Tue, 15 Mar 2016 11:29:03 +0000
Subject: [PATCH] Fix typo in previous gdb/doc/ commit

Should be s/reliability/reliably/.

gdb/doc/ChangeLog:
2016-03-15 Pedro Alves <palves@redhat.com>

* gdb.texinfo (Tracepoint Actions): Fix typo.
---
gdb/doc/ChangeLog | 4 ++++
gdb/doc/gdb.texinfo | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 0606d9d..a48d1c4 100644
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,4 +1,8 @@
2016-03-15 Pedro Alves <palves@redhat.com>
+
+ * gdb.texinfo (Tracepoint Actions): Fix typo.
+
+2016-03-15 Pedro Alves <palves@redhat.com>
Andreas Arnez <arnez@linux.vnet.ibm.com>
Marcin KoÅ›cielnicki <koriakin@0x04.net>

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 5f88335..71657b0 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -12878,7 +12878,7 @@ Collect all local variables.
Collect the return address. This is helpful if you want to see more
of a backtrace.

-@emph{Note:} The return address location can not always be reliability
+@emph{Note:} The return address location can not always be reliably
determined up front, and the wrong address / registers may end up
collected instead. On some architectures the reliability is higher
for tracepoints at function entry, while on others it's the opposite.
--
2.5.0