Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.

Marcin Kościelnicki
2016-02-18T16:01:10Z

On 18/02/16 16:58, Ulrich Weigand wrote:
> Marcin KoÃ…Â›cielnicki wrote:
>> On 18/02/16 16:40, Ulrich Weigand wrote:
>>> I don't think you actually need this include, do you?
>>>
>>> Otherwise, this patch is OK.
>>>
>>> Bye,
>>> Ulrich
>>>
>>
>> I do, the default_guess_tracepoint_registers function is declared there,
>> and gdbarch.c uses it.
>
> Ah, right. You should probably move the prototype to arch-utils.h
> (and then the implementation to arch-utils.c) to go with the other
> default_ functions.

Alright, I'll do that.
>
> Since gdbarch.h is included everywhere, we try to avoid having it
> include other headers as far as possible.

FWIW, the header include I added only ends up in gdbarch.c, .h is
unaffected.
>
> Bye,
> Ulrich
>