From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121616 invoked by alias); 10 Mar 2016 20:19:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121603 invoked by uid 89); 10 Mar 2016 20:19:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=UD:gdb.python, UD:python, gdb.python, gdbpython X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Mar 2016 20:19:21 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 31509C057EC2; Thu, 10 Mar 2016 20:19:20 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2AKJIeI008065; Thu, 10 Mar 2016 15:19:19 -0500 Subject: Re: [PATCH] Add $_as_string convenience function To: Simon Marchi , gdb-patches@sourceware.org References: <1457124218-22342-1-git-send-email-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <56E1D6C6.9010004@redhat.com> Date: Thu, 10 Mar 2016 20:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457124218-22342-1-git-send-email-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00166.txt.bz2 On 03/04/2016 08:43 PM, Simon Marchi wrote: > This patch is a follow-up to "Add printf format specifier for printing > enumerator": > > https://sourceware.org/ml/gdb-patches/2016-02/msg00144.html > > Instead of having a solution specific to the printf command, Pedro > suggested adding a general purpose function $_as_string() that would > cover this use case and more. > > So, in order to print the textual label of an enum, one can use: > > (gdb) printf "Visiting node of type %s\n", $_as_string(node) > Visiting node of type NODE_INTEGER > > gdb/ChangeLog: > > * data-directory/Makefile.in (PYTHON_FILE_LIST): Install > gdb/function/as_string.py. > * python/lib/gdb/function/as_string.py: New file. > > gdb/testsuite/ChangeLog: > > * gdb.python/py-as-string.exp: New file. > * gdb.python/py-as-string.c: New file. > > gdb/doc/ChangeLog: > > * gdb.texinfo (Convenience Functions): Document $_as_string. LGTM, thanks for doing this. Thanks, Pedro Alves