From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90398 invoked by alias); 10 Mar 2016 17:17:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90382 invoked by uid 89); 10 Mar 2016 17:17:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=cleans, nat, 607, 604 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 10 Mar 2016 17:17:23 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 44EDC7F0A2; Thu, 10 Mar 2016 17:17:22 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2AHHKrE017399; Thu, 10 Mar 2016 12:17:20 -0500 Subject: Re: [PATCH 0/2] xtensa: add hardware breakpoints support To: Max Filippov , gdb-patches@sourceware.org References: <1457560106-5830-1-git-send-email-jcmvbkbc@gmail.com> Cc: Maxim Grigoriev , Woody LaRue , Marc Gauthier , linux-xtensa@linux-xtensa.org From: Pedro Alves Message-ID: <56E1AC20.30405@redhat.com> Date: Thu, 10 Mar 2016 17:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457560106-5830-1-git-send-email-jcmvbkbc@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00163.txt.bz2 On 03/09/2016 09:48 PM, Max Filippov wrote: > Hello, > > this series cleans up gdb/xtensa-linux-nat.c so that it builds without > warnings and adds support for hardware breakpoints and watchpoints. > The implementation closely follows what ARM does. > Please review. Unfortunately, you looked at one of the targets that still doesn't share the debug registers code with gdbserver. See how at least x86, aarch64 and mips put debug registers code in gdb/nat/. I think we should require all new GNU/Linux debug registers support code follow such a scheme. Patch #1 is obvious, please push it in. > > Max Filippov (2): > gdb: xtensa: make locally used functions static > gdb: xtensa: support hardware breakpoints/watchpoints > > gdb/xtensa-linux-nat.c | 607 ++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 604 insertions(+), 3 deletions(-) Thanks, Pedro Alves