From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62644 invoked by alias); 9 Mar 2016 17:27:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62629 invoked by uid 89); 9 Mar 2016 17:27:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1061, Bye, our, HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Mar 2016 17:27:18 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id ADA82400E4; Wed, 9 Mar 2016 18:28:14 +0100 (CET) Received: from [192.168.1.62] (84-10-2-59.static.chello.pl [84.10.2.59]) by hogfather.0x04.net (Postfix) with ESMTPSA id B01275800FB; Wed, 9 Mar 2016 18:27:15 +0100 (CET) Subject: Re: [PATCH 4/8] gdb.trace: Use manually-defined start labels in unavailable-dwarf-piece.exp To: Ulrich Weigand References: <20160309172438.7ADA4C88E@oc7340732750.ibm.com> Cc: gdb-patches@sourceware.org From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56E05CF2.8020305@0x04.net> Date: Wed, 09 Mar 2016 17:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160309172438.7ADA4C88E@oc7340732750.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00140.txt.bz2 On 09/03/16 18:24, Ulrich Weigand wrote: > Marcin Kościelnicki wrote: > >> On powerpc64, foo/bar point to a function descriptor, not to function code. >> Since there are no global labels pointing at the actual function code, >> let's make our own. > >> with_test_prefix "tracing foo" { >> - gdb_test "trace foo" ".*" >> + gdb_test "trace *foo_start_lbl" ".*" > > Well, I'd have thought that "trace foo" should simply work as-is, > otherwise, this isn't particularly user-friedly ... > > Is there a call to gdbarch_convert_from_func_ptr_addr missing > somewhere in the trace code, maybe? Don't worry, trace foo does work, but not for this particular test, because of the way the fake DWARF is emitted: before, the DWARF covered area from foo to foo_end_lbl, and thus a tracepoint set on foo worked just fine. However, now the DWARF covers foo_start_lbl to foo_end_lbl - and function entry point (which is where the tracepoint is) is not covered. > > Bye, > Ulrich >