From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114035 invoked by alias); 9 Mar 2016 15:58:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113947 invoked by uid 89); 9 Mar 2016 15:58:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=descriptions, XML, alright, our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Mar 2016 15:58:33 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id AEF7D19CB83; Wed, 9 Mar 2016 15:58:31 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u29FwUxl023567; Wed, 9 Mar 2016 10:58:30 -0500 Subject: Re: [PATCH] Avoid spaces in osabi names To: Joel Brobecker References: <1457377364-990-1-git-send-email-palves@redhat.com> <20160308205913.GA5911@adacore.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <56E04826.2000709@redhat.com> Date: Wed, 09 Mar 2016 15:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160308205913.GA5911@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00129.txt.bz2 On 03/08/2016 08:59 PM, Joel Brobecker wrote: > Hi Pedro, > >> gdb/ChangeLog: >> 2016-03-07 Pedro Alves >> >> * osabi.c (gdb_osabi_names): Avoid spaces in osabi names. > > FWIW, I think this is the best compromise. The new names you chose > also look good to me. Alright, pushed. Thanks. I should point out: the osabi can also be sent in XML target descriptions, but gdbserver is currently only including an element on GNU/Linux target descriptions. Hopefully no stub outside our tree is sending any of the affected names. Thanks, Pedro Alves