From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72877 invoked by alias); 29 Feb 2016 18:55:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72798 invoked by uid 89); 29 Feb 2016 18:55:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=avoided, evans, skipped, Evans X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 29 Feb 2016 18:55:27 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 27.16.12433.1BF84D65; Mon, 29 Feb 2016 19:36:33 +0100 (CET) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.89) with Microsoft SMTP Server id 14.3.248.2; Mon, 29 Feb 2016 13:55:24 -0500 Subject: Re: [PATCH, doc RFA] Add "skip regexp" To: Doug Evans , Pedro Alves , References: <001a113452243e6481052bece0b3@google.com> CC: From: Simon Marchi Message-ID: <56D4941C.1080008@ericsson.com> Date: Mon, 29 Feb 2016 18:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <001a113452243e6481052bece0b3@google.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00891.txt.bz2 On 16-02-16 08:07 PM, Doug Evans wrote: > +# Test -fi + -fu. > + > +if ![runto_main] { > + fail "Can't run to main" > + return > +} > + > +set test "step using -fi + -fu" > +gdb_test_no_output "skip delete" > +gdb_test "skip -fi skip1.c -fu test_skip" \ > + "Function test_skip in file skip1.c will be skipped when stepping\." > +gdb_breakpoint "test_skip_file_and_function" > +gdb_breakpoint "end_test_skip_file_and_function" > +gdb_test "call test_skip_file_and_function ()" "silently stop." Hi Doug, I just saw a failure of this test on a target that doesn't have inferior calls. It seems to me like the function call isn't fundamental to the test and it could be avoided by organizing things differently. What do you think? Otherwise, we would need to add a if [target_info exists gdb,cannot_call_functions] { Simon