Re: [PATCH 0/2] Decouple ARM instruction decoding/relocating from GDB

Yao Qi
2016-03-04T12:03:46Z

Simon Marchi <simon.marchi@ericsson.com> writes:

Hi Simon,

> As part of the upcoming ARM fast tracepoint support, we need to have some code
> in gdbserver that decodes the relocated instructions, to check whether they
> need to be modified or not (whether the result of their execution depends on
> their particular PC). Instead of writing new code from scratch, we should take
> advantage of the code already written for the displaced stepping feature in
> GDB, as AArch64 does. To make this possible, we first need to decouple the
> instruction decoding part from GDB, so that the code can eventually be moved to
> a shared location.

Could you include these two patches into your arm fast tracepoint patch
series? The problems in the code can't be found until we use the code,
so I'd like to review them together when arm fast tracepoint patches are
ready.

--
Yao (齐尧)