From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73505 invoked by alias); 25 Feb 2016 19:23:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73489 invoked by uid 89); 25 Feb 2016 19:23:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2103, HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Feb 2016 19:23:24 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 377A33FED6 for ; Thu, 25 Feb 2016 20:24:17 +0100 (CET) Received: from [192.168.13.108] (unknown [192.168.13.108]) by hogfather.0x04.net (Postfix) with ESMTPSA id 902A95800FC for ; Thu, 25 Feb 2016 20:23:22 +0100 (CET) Subject: Re: [PATCH 4/8] gdb/s390: Fill gen_return_address hook. To: gdb-patches@sourceware.org References: <1453637529-26972-5-git-send-email-koriakin@0x04.net> <1454853751-18455-1-git-send-email-koriakin@0x04.net> From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56CF54AA.2080302@0x04.net> Date: Thu, 25 Feb 2016 19:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1454853751-18455-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00831.txt.bz2 Ping. On 07/02/16 15:02, Marcin Kościelnicki wrote: > gdb/ChangeLog: > > * s390-linux-tdep.c (s390_gen_return_address): New function. > (s390_gdbarch_init): Fill gen_return_address hook. > --- > Added missing comment. > > gdb/ChangeLog | 5 +++++ > gdb/s390-linux-tdep.c | 13 +++++++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 6260040..0cf8bfc 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,5 +1,10 @@ > 2016-02-07 Marcin Kościelnicki > > + * s390-linux-tdep.c (s390_gen_return_address): New function. > + (s390_gdbarch_init): Fill gen_return_address hook. > + > +2016-02-07 Marcin Kościelnicki > + > * s390-linux-tdep.c (s390_ax_pseudo_register_collect): New function. > (s390_ax_pseudo_register_push_stack): New function. > (s390_gdbarch_init): Fill ax_pseudo_register_collect and > diff --git a/gdb/s390-linux-tdep.c b/gdb/s390-linux-tdep.c > index 97bd564..0b91ed1 100644 > --- a/gdb/s390-linux-tdep.c > +++ b/gdb/s390-linux-tdep.c > @@ -627,6 +627,18 @@ s390_ax_pseudo_register_push_stack (struct gdbarch *gdbarch, > return 0; > } > > +/* The "gen_return_address" gdbarch method. */ > + > +static void > +s390_gen_return_address (struct gdbarch *gdbarch, > + struct agent_expr *ax, struct axs_value *value, > + CORE_ADDR scope) > +{ > + value->type = register_type (gdbarch, S390_R14_REGNUM); > + value->kind = axs_lvalue_register; > + value->u.reg = S390_R14_REGNUM; > +} > + > > /* A helper for s390_software_single_step, decides if an instruction > is a partial-execution instruction that needs to be executed until > @@ -7970,6 +7982,7 @@ s390_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) > s390_ax_pseudo_register_collect); > set_gdbarch_ax_pseudo_register_push_stack > (gdbarch, s390_ax_pseudo_register_push_stack); > + set_gdbarch_gen_return_address (gdbarch, s390_gen_return_address); > tdesc_use_registers (gdbarch, tdesc, tdesc_data); > set_gdbarch_register_name (gdbarch, s390_register_name); > >