From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52312 invoked by alias); 25 Feb 2016 17:59:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52299 invoked by uid 89); 25 Feb 2016 17:59:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:817 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Feb 2016 17:59:14 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 1B2DD64393; Thu, 25 Feb 2016 17:59:13 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1PHxBJZ001222; Thu, 25 Feb 2016 12:59:12 -0500 Message-ID: <56CF40EF.8090308@redhat.com> Date: Thu, 25 Feb 2016 17:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org, qiyaoltc@gmail.com Subject: Re: [PATCH v6] Enable tracing of pseudo-registers on ARM References: <861t81cc2c.fsf@gmail.com> <1456414378-1918-1-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1456414378-1918-1-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00820.txt.bz2 On 02/25/2016 03:32 PM, Antoine Tremblay wrote: > In this v6: > * use https://sourceware.org/ml/gdb-patches/2016-02/msg00786.html to map > registers to remote registers. (This is already in master) > * Fix test changelog > * Test is already renamed, update patch. > - > This patch implements the ax_pseudo_register_push_stack and > ax_pseudo_register_collect gdbarch functions so that a pseudo-register can > be traced. > FAOD, I'm happy with this version, if Yao is happy. > dummy (void) > @@ -37,6 +41,7 @@ main (void) > { > /* Strictly speaking, it should be ymm15 (xmm15 is 128-bit), but gcc older > than 4.9 doesn't recognize "ymm15" as a valid register name. */ > +#if (defined __x86_64__) The comment should be within the #if. Thanks, Pedro Alves