From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21879 invoked by alias); 25 Feb 2016 17:12:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21867 invoked by uid 89); 25 Feb 2016 17:11:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Feb 2016 17:11:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id DBBEA8E3FB; Thu, 25 Feb 2016 17:11:57 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1PHBuxR002229; Thu, 25 Feb 2016 12:11:57 -0500 Message-ID: <56CF35DC.5040204@redhat.com> Date: Thu, 25 Feb 2016 17:12:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/8] [GDBserver] Leave child suspended when step over parent References: <1455892594-2294-1-git-send-email-yao.qi@linaro.org> <1455892594-2294-2-git-send-email-yao.qi@linaro.org> In-Reply-To: <1455892594-2294-2-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00808.txt.bz2 LGTM. On 02/19/2016 02:36 PM, Yao Qi wrote: > /* If we're suspending all threads, leave this one suspended > - too. */ > - if (stopping_threads == STOPPING_AND_SUSPENDING_THREADS) > + too. If we're stepping over the parent, all other threads > + have been suspended already, leave this one suspended too. */ I'd write: too. If the fork/clone parent is stepping over a breakpoint, all other threads have been suspended already. Leave the child suspended too. */ Thanks, Pedro Alves