From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102635 invoked by alias); 25 Feb 2016 16:59:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102622 invoked by uid 89); 25 Feb 2016 16:59:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:192.168.8, H*r:sk:user-94, Hx-languages-length:502, H*RU:sk:user-94 X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Feb 2016 16:59:18 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id C6C343FED6; Thu, 25 Feb 2016 18:00:10 +0100 (CET) Received: from [192.168.8.147] (user-94-254-168-77.play-internet.pl [94.254.168.77]) by hogfather.0x04.net (Postfix) with ESMTPSA id 1956A5800FC; Thu, 25 Feb 2016 17:59:16 +0100 (CET) Subject: Re: [PATCH] [PR gdb/13808] gdb.trace: Pass tdesc selected in gdbserver to IPA. To: Pedro Alves References: <56CF13A5.2020909@redhat.com> <1456414790-12228-1-git-send-email-koriakin@0x04.net> <56CF2FEF.3090407@redhat.com> Cc: gdb-patches@sourceware.org, antoine.tremblay@ericsson.com From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56CF32E3.4040001@0x04.net> Date: Thu, 25 Feb 2016 16:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56CF2FEF.3090407@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00806.txt.bz2 On 25/02/16 17:46, Pedro Alves wrote: > On 02/25/2016 03:39 PM, Marcin Kościelnicki wrote: >> >> + /* Tell IPA about the correct tdesc. */ >> + if (write_inferior_integer (ipa_sym_addrs.addr_ipa_tdesc_idx, >> + target_get_ipa_tdesc_idx ())) >> + { >> + error ("Error setting ipa_tdesc_idx variable in lib"); >> + } >> + > > No {}s for single-line statement. > > Otherwise OK. > > Thanks, > Pedro Alves > Thanks, pushed.