Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Marcin Kościelnicki" <koriakin@0x04.net>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Cc: antoine.tremblay@ericsson.com
Subject: Re: [PATCH 2/3] gdb.trace: Surround $call_insn with \y in entry-values.exp
Date: Thu, 25 Feb 2016 15:12:00 -0000	[thread overview]
Message-ID: <56CF19E2.8050602@0x04.net> (raw)
In-Reply-To: <56CF0D78.8080003@redhat.com>

On 25/02/16 15:19, Pedro Alves wrote:
> On 02/20/2016 02:02 PM, Marcin Kościelnicki wrote:
>> The PPC64 tracepoint patch added \y at the end of the call_insn pattern -
>> without that, it embarassed itself and matched the 'bl' in "Dump of
>> assem*bl*er code for function" as the powerpc call opcode.  Since that
>> sounds like a generally good idea, I've added \y before and after
>> call_insn for every target.  As a result, I had to change x86_64's mnemonic
>> to 'callq'.
>>
>
> OK.
>
> Thanks,
> Pedro Alves
>

Thanks, pushed.


  reply	other threads:[~2016-02-25 15:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 12:23 [PATCH] gdb.trace: Move more target dependencies to trace-support.exp Marcin Kościelnicki
2016-02-19 15:05 ` Antoine Tremblay
2016-02-19 15:18   ` Marcin Kościelnicki
2016-02-20 14:02     ` [PATCH 1/3] " Marcin Kościelnicki
2016-02-20 14:02       ` [PATCH 2/3] gdb.trace: Surround $call_insn with \y in entry-values.exp Marcin Kościelnicki
2016-02-25 14:19         ` Pedro Alves
2016-02-25 15:12           ` Marcin Kościelnicki [this message]
2016-02-20 14:02       ` [PATCH 3/3] gdb.trace: Remove unnecessary target check from ftrace.exp Marcin Kościelnicki
2016-02-25 14:22         ` Pedro Alves
2016-02-25 15:12           ` Marcin Kościelnicki
2016-02-25 13:45 ` [PATCH] gdb.trace: Move more target dependencies to trace-support.exp Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56CF19E2.8050602@0x04.net \
    --to=koriakin@0x04.net \
    --cc=antoine.tremblay@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox